Skip to content

Sync published ANcpLua package versions #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ANcpLua merged 1 commit into from
May 7, 2026
Merged

Sync published ANcpLua package versions #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Version.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,28 +22,28 @@
ROSLYN.UTILITIES (Runtime package)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities">
<ANcpLuaRoslynUtilitiesVersion>2.2.0</ANcpLuaRoslynUtilitiesVersion>
<ANcpLuaRoslynUtilitiesVersion>2.2.5</ANcpLuaRoslynUtilitiesVersion>
</PropertyGroup>

<!-- ═══════════════════════════════════════════════════════════════════════
ROSLYN.UTILITIES.SOURCES (Source-only package for generators)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities.Sources">
<ANcpLuaRoslynUtilitiesSourcesVersion>2.2.0</ANcpLuaRoslynUtilitiesSourcesVersion>
<ANcpLuaRoslynUtilitiesSourcesVersion>2.2.5</ANcpLuaRoslynUtilitiesSourcesVersion>
</PropertyGroup>

<!-- ═══════════════════════════════════════════════════════════════════════
ROSLYN.UTILITIES.POLYFILLS (Source-only polyfills for netstandard2.0)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities.Polyfills">
<ANcpLuaRoslynUtilitiesPolyfillsVersion>2.2.0</ANcpLuaRoslynUtilitiesPolyfillsVersion>
<ANcpLuaRoslynUtilitiesPolyfillsVersion>2.2.5</ANcpLuaRoslynUtilitiesPolyfillsVersion>
</PropertyGroup>

<!-- ═══════════════════════════════════════════════════════════════════════
ROSLYN.UTILITIES.TESTING (Analyzer/CodeFix/Generator test infrastructure)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities.Testing">
<ANcpLuaRoslynUtilitiesTestingVersion>2.2.0</ANcpLuaRoslynUtilitiesTestingVersion>
<ANcpLuaRoslynUtilitiesTestingVersion>2.2.5</ANcpLuaRoslynUtilitiesTestingVersion>
</PropertyGroup>

<!-- ═══════════════════════════════════════════════════════════════════════
Expand All @@ -58,7 +58,7 @@
ANALYZERS (SDK-injected)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Analyzers">
<ANcpLuaAnalyzersVersion>1.29.0</ANcpLuaAnalyzersVersion>
<ANcpLuaAnalyzersVersion>1.29.1</ANcpLuaAnalyzersVersion>

@coderabbitai coderabbitai Bot May 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Blocking: ANcpLuaAnalyzersVersion does not mirror the latest repository tag

Line 61 sets ANcpLuaAnalyzersVersion to 1.29.1, but the latest GitHub release/tag visible for this repo is v1.20.1 (March 20, 2026). That breaks the tag-driven version invariant and can desync publish automation.

As per coding guidelines, "Version.props: Single source of truth for version. Manual-tag-triggers-publish pattern: the tag name (vX.Y.Z) drives the version, this file mirrors it. Review for: matches latest tag intention. Flag if mismatched with recent tag."

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Version.props` at line 61, The ANcpLuaAnalyzersVersion value in Version.props
(element ANcpLuaAnalyzersVersion) is incorrect (set to 1.29.1) and must mirror
the repository tag; update the element content to match the latest tag (v1.20.1
→ set ANcpLuaAnalyzersVersion to 1.20.1) so the file remains the single source
of truth for tag-driven publishing and automation.

<JonSkeetAnalyzersVersion>1.0.0-beta.6</JonSkeetAnalyzersVersion>
</PropertyGroup>

Expand All @@ -69,4 +69,4 @@
<XunitMtpVersion>$(XunitV3Version)</XunitMtpVersion>
<MvcTestingVersion>$(AspNetCoreVersion)</MvcTestingVersion>
</PropertyGroup>
</Project>
</Project>
Loading