-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Use GNUInstallDirs CMake module #1062
Conversation
Trying to enable installation to the correct lib dir for each platform
I believe this line: https://github.com/ANTsX/ANTs/blob/master/ANTS.cmake#L199 Needs to have "lib" changed to ${CMAKE_INSTALL_LIBDIR} |
I think I've set all the variables correctly, but CMAKE_INSTALL_LIBDIR does not get propagated to the ANTS-build. A workaround is to go to ANTS-build and then
I'm trying to figure out how to make ANTS use the Superbuild value |
This is probably related to "make install" not working properly at the superbuild level, but rather needs to happen inside ANTS after the final build. |
I'm thinking it is independently detecting |
OK I think that last commit does the trick, I can now build with VTK and send libs to lib64. Update: I spoke too soon, I forgot to turn shared libs on. Trying again |
CMAKE_INSTALL_LIBDIR=lib64
I think I may have finally cracked it. Things were going wrong because when I would be grateful if anyone could test this on a non-Mac OS system. |
Builds and installs properly on Ubuntu 18.04 |
This is @cookpa's work. Given it fixes some outstanding bugs #872 we should merge.
Trying to enable installation to the correct lib dir for each platform.
This just needs the SuperBuild bits still adjusted, I will provide feedback.