Skip to content

fix: preserve heredoc command ownership in lifecycle guard - #933

Merged
Kyzcreig merged 2 commits into
mainfrom
fix/lifecycle-heredoc-safety-9978
Sep 23, 2026
Merged

Kyzcreig merged 2 commits into
mainfrom
fix/lifecycle-heredoc-safety-9978

Conversation

@Kyzcreig

@Kyzcreig Kyzcreig commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Fix forward for #920: attribute heredoc bodies to the command bearing the redirection, not a later semicolon command; fail closed if trusted diagnostic callables are rebound. Retains the original read-only incident parity and lifecycle blocking. Verified the captured incident text against a disposable log and 590 focused lifecycle/heredoc tests; Ruff clean. Security-sensitive regression details are retained on the private Kanban task.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Verified 590 focused lifecycle/heredoc tests and original incident fixture against fork/main; Ruff clean.
Verified 595 focused tests, original incident parity, and 4/4 previous-head RED controls. Ruff clean.
@Kyzcreig
Kyzcreig added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit 53f300f Sep 23, 2026
54 checks passed
@Kyzcreig
Kyzcreig deleted the fix/lifecycle-heredoc-safety-9978 branch September 23, 2026 19:53
@Kyzcreig Kyzcreig added the fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent) label Sep 24, 2026
@Kyzcreig

Copy link
Copy Markdown
Collaborator Author

🤖 merged-by: fleet-drift-watch · lane: self-heal · gate: RETROACTIVE: already merged; FleetReview gate not applicable to --record-only · why: fleet-drift-watch PR self-heal (FDW_PR_SELF_HEAL default 1) auto-armed this PR bare on 2026-09-23; retroactive record. Actuator disabled in 7a8537d2e

Kyzcreig added a commit that referenced this pull request Sep 25, 2026
…009b, batch 3)

#278 and lifecycle-guard bundles (#319+#594, ssh trio, #920+#933+#1017, #740, #767) re-ported onto upstream/main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant