Repository navigation
fix(failover): keep Tailscale errors terse - #622
Merged
Merged
Conversation
Kyzcreig
enabled auto-merge
August 20, 2026 04:21
Kyzcreig
added a commit
that referenced
this pull request
Sep 25, 2026
…621)" This reverts commit 7a4455f, stacked on the clean #622 revert (6c344e3). Hand-resolved (audit t_712c13f2, DROP): - agent/chat_completion_helpers.py, agent/conversation_loop.py: drop the Tailscale preflight blocks (HEAD carried only cosmetic later edits to them); inline _POOLED_PROVIDERS = frozenset({claude-apr, claude-bpr}) since #913 imported _TAILSCALE_RELAY_PROVIDERS from the deleted module. - tests/agent/test_error_classifier.py: drop tailscale_down from the enum list, keep the later pool_stalled member. Verified: test-gate pytest tests/agent/test_error_classifier.py tests/agent/test_fallback_reason_surfacing.py tests/agent/test_fallback_reason_threading.py -> 166 passed; tests/hermes_cli/test_user_providers_model_switch.py tests/run_agent/test_primary_runtime_restore.py -> 63 passed, 2 failed (same 2 node ids fail on clean origin/main 59102f4: inherited).
Kyzcreig
added a commit
that referenced
this pull request
Sep 25, 2026
…621)" This reverts commit 7a4455f, stacked on the clean #622 revert (6c344e3). Hand-resolved (audit t_712c13f2, DROP): - agent/chat_completion_helpers.py, agent/conversation_loop.py: drop the Tailscale preflight blocks (HEAD carried only cosmetic later edits to them); inline _POOLED_PROVIDERS = frozenset({claude-apr, claude-bpr}) since #913 imported _TAILSCALE_RELAY_PROVIDERS from the deleted module. - tests/agent/test_error_classifier.py: drop tailscale_down from the enum list, keep the later pool_stalled member. Verified: test-gate pytest tests/agent/test_error_classifier.py tests/agent/test_fallback_reason_surfacing.py tests/agent/test_fallback_reason_threading.py -> 166 passed; tests/hermes_cli/test_user_providers_model_switch.py tests/run_agent/test_primary_runtime_restore.py -> 63 passed, 2 failed (same 2 node ids fail on clean origin/main 59102f4: inherited).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #621: enforce Ace's final UX requirement that human-facing Tailscale outage errors are the two-word causal label
Tailscale down.⚠️ Tailscale downTailscale down/modelrejection:Tailscale downVerification
git diff --checkpassed