Skip to content

feat(kanban): CLI auto-subscribe knob + dispatch unwatched warning (fork-adapted from #80564) - #470

Merged
Kyzcreig merged 1 commit into
mainfrom
kanban-cli-auto-subscribe-fork
Aug 6, 2026
Merged

feat(kanban): CLI auto-subscribe knob + dispatch unwatched warning (fork-adapted from #80564)#470
Kyzcreig merged 1 commit into
mainfrom
kanban-cli-auto-subscribe-fork

Conversation

@Kyzcreig

@Kyzcreig Kyzcreig commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Forces upstream PR NousResearch#80564 across to fork main by hand (Ace, 2026-08-06).

Fork main is ~692 commits behind upstream, so the upstream PR did not cherry-pick clean — it depends on the config_defaults.py extraction and add_notify_sub chat_type/delivery_metadata params this fork lacks. Adapted for the fork layout: default re-homed to config.py; add_notify_sub call drops the two upstream-only kwargs (parity NOTE in source); the test assertion on those columns scoped to row-written behaviour (parity NOTE).

Feature works on fork: agent-session CLI create subscribes its origin chat; dispatch prints an unwatched-card warning. 12/12 tests green, RED-proven. Full upstream enrichment returns at the next upstream->fork parity merge.

…ork-adapted from NousResearch#80564)

Forced NousResearch#80564 across to fork main by hand (Ace, 2026-08-06). The upstream PR
was authored against upstream main; fork main is ~692 commits behind, so it
lacks: (a) the config_defaults.py extraction (fork keeps the default in
config.py) and (b) add_notify_sub chat_type/delivery_metadata params. Adapted:
default re-homed to config.py; the add_notify_sub call drops the two
upstream-only kwargs; the one test assertion on those columns is scoped to the
row-written behaviour with a parity NOTE. Feature (agent-session CLI create
subscribes its origin chat + dispatch unwatched-card warning) works on fork.
12/12 tests green, RED-proven. Full upstream enrichment returns at the next
upstream->fork parity merge.
@Kyzcreig
Kyzcreig enabled auto-merge August 6, 2026 20:53
@Kyzcreig

Kyzcreig commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

FleetReview

Confidence: 1/5

Findings

  • P1 hermes_cli/kanban.py:1873 — Misleading Reclaim
  • P2 hermes_cli/kanban.py:2524 — Dry-run Warning
  • P0 hermes_cli/kanban.py:2531dispatch output drops respawn_guarded from both JSON and text — deferred cards become invisible, test breaks
  • P0 tests/hermes_cli/test_kanban_cli_auto_subscribe.py:15 — Missing Implementation
  • P1 tests/hermes_cli/test_kanban_cli_auto_subscribe.py:206 — Rollback Blindspot
  • P0 tools/kanban_tools.py:74 — Imports non-existent is_dispatcher_owned_worker_context
  • P0 tools/kanban_tools.py:170_current_session_id() deleted — reintroduces the cross-session id clobber and breaks its dedicated regression suite
  • P1 tools/kanban_tools.py:362 — Cross-context steering
  • P1 tools/kanban_tools.py:386 — Startup note loss
  • P1 tools/kanban_tools.py:393 — Premature watermark
  • P0 tools/kanban_tools.py:1242 — Deleting _current_session_id() regresses gateway session attribution and breaks its test suite
  • P0 tools/kanban_tools.py:1281kanban_create silently drops model_override; arg validation and the schema property were removed
  • P0 hermes_cli/kanban.py:161gateway.status.resolve_gateway_liveness does not exist — dispatcher-presence warning is now permanently dead (and 2 tests fail)
  • P0 hermes_cli/kanban.py:2812kanban notify-subscribe passes chat_type= to kb.add_notify_sub, which has no such parameter — TypeError on every subscribe
  • P0 hermes_cli/kanban.py:609kanban edit --model / --clear-model removed and --result made mandatory — working feature deleted, 4 tests broken
  • P1 tools/kanban_tools.py:373kb.list_comments_after does not exist — operator-note injection silently never fires
  • P1 tools/kanban_tools.py:350 — Live operator-note injection is never invoked
  • P1 hermes_cli/kanban.py:1552 — CLI auto-subscribe ignores --json, violating documented no-side-effect contract

FleetReview provenance · models: B=gpt-5.6-sol, C=claude-code-opus-4-8, F=gpt-5.6-sol, G=grok-4.5 · cost: $13.71 · duration: 20m 58s · rounds: 2 · files examined: 5

@Kyzcreig
Kyzcreig added this pull request to the merge queue Aug 6, 2026
Merged via the queue into main with commit 11cffc4 Aug 6, 2026
@Kyzcreig
Kyzcreig deleted the kanban-cli-auto-subscribe-fork branch August 6, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant