test(s6): document macOS mode relaxation

[Kyzcreig]

Summary

Document why the s6 event-directory mode assertion is platform-adaptive: Linux CI remains authoritative for the production 03730 setgid contract, while Darwin's temp filesystem strips setgid and can only assert 01730 locally.

Follow-up to Greptile's P2 on #345.

Verification

• scripts/run_tests.sh tests/hermes_cli/test_service_manager.py -q → 66 passed
• Ruff → passed
• git diff --check → passed

[greptile-apps]

Greptile Summary

Adds a three-line comment to test_seed_supervise_skeleton_creates_expected_layout documenting why the s6 event/ directory mode check is platform-adaptive.

• The existing 0o1730 / 0o3730 conditional was already present; this commit only adds prose explaining that Linux CI is the authoritative source for the 03730 setgid contract while macOS tmp filesystems silently strip the setgid bit, making 01730 the correct local expectation on Darwin.

Confidence Score: 5/5

Comment-only change with no effect on test logic or production code; safe to merge.

The entire diff is three lines of inline comments added above an already-existing conditional. No test assertions, no source code, and no fixtures were modified.

No files require special attention.

Important Files Changed

Filename	Overview
tests/hermes_cli/test_service_manager.py	Three-line comment added above an existing platform-adaptive mode assertion; no logic or test behaviour changed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[test_seed_supervise_skeleton_creates_expected_layout] --> B{sys.platform == darwin?}
    B -- Yes --> C[expected_event_mode = 0o1730\nmacOS tmp strips setgid bit]
    B -- No --> D[expected_event_mode = 0o3730\nLinux CI enforces full setgid contract]
    C --> E[assert S_IMODE == expected_event_mode]
    D --> E

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[test_seed_supervise_skeleton_creates_expected_layout] --> B{sys.platform == darwin?}
    B -- Yes --> C[expected_event_mode = 0o1730\nmacOS tmp strips setgid bit]
    B -- No --> D[expected_event_mode = 0o3730\nLinux CI enforces full setgid contract]
    C --> E[assert S_IMODE == expected_event_mode]
    D --> E

Loading

_{Reviews (1): Last reviewed commit: "test(s6): document macOS mode relaxation" | Re-trigger Greptile}