Skip to content

fix: FleetReview #1371 P1s -- newly-skipped job blocks full re-run; atomic capture-router staging (t_06bf7c49) - #1422

Merged
ang-fleet-lander[bot] merged 1 commit into
mainfrom
daedalus/t_06bf7c49-fleetreview-1371-p1
Sep 28, 2026
Merged

ang-fleet-lander[bot] merged 1 commit into
mainfrom
daedalus/t_06bf7c49-fleetreview-1371-p1

Conversation

@ang-fleet-workers

Copy link
Copy Markdown

Kanban t_06bf7c49. Two FleetReview P1 findings on #1371 @430c5ba9, both real-open on main 667885f.

  1. scripts/ci_overflow_integration.py (fb763f44): full_rerun_verdict let a job that ran in attempt N but was skipped (started_at null) in N+1 through: not reused, not missing_probe, not absent -> PASS. Now BLOCK with evidence.newly_skipped; skipped-in-both stays exempt.
  2. plugins/memory/mem0/capture_router.py (d82676bc): route_turn treats an existing <turn_id>.md as a completed stage, but _default_write wrote in place. Now tmp (non-.md name) + fsync + os.replace.

Tests: one regression test each; both fail on main, pass here. 41 passed across tests/test_ci_overflow_integration.py and tests/plugins/memory/test_mem0_capture_router_retry.py.

… verdict; atomic capture-router staging write (t_06bf7c49)

- ci_overflow_integration.full_rerun_verdict: a job that started in the prior
  attempt but never started in the re-run now BLOCKs (newly_skipped); jobs
  skipped in both attempts stay exempt.
- capture_router._default_write: write to <path>.<pid>.tmp, fsync, os.replace,
  so route_turn's existing-<turn_id>.md retry short-circuit never sees a
  truncated stage.

Verified: both new regression tests fail on 667885f and pass with the fix;
tests/test_ci_overflow_integration.py + test_mem0_capture_router_retry.py 41 passed.
@ang-prism

ang-prism Bot commented Sep 28, 2026

Copy link
Copy Markdown

FleetReview

Below the merit threshold, review skipped (74 changed lines < 150 and 4 changed files < 6, no hot path touched; skipped by policy).


FleetReview · reviewKind: skipped-by-policy

@ang-fleet-lander

Copy link
Copy Markdown

🤖 merged-by: apollo · lane: kanban-merge-pass · gate: fleetreview d62ffe6 green · why: t_06bf7c49: FleetReview P1: #1371 @430c5ba9 scripts/ci_overflow_int; Argus off card review (Ace 13:08), CI green

@ang-fleet-lander
ang-fleet-lander Bot added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit 40e107f Sep 28, 2026
41 checks passed
@ang-fleet-lander
ang-fleet-lander Bot deleted the daedalus/t_06bf7c49-fleetreview-1371-p1 branch September 28, 2026 16:26
@ang-fleet-ci-actuators ang-fleet-ci-actuators Bot added the fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent) label Sep 28, 2026
@ang-prism

ang-prism Bot commented Sep 28, 2026

Copy link
Copy Markdown

FleetReview

Review: post-merge · head 40e107f32f4e · duration 1m 28s
Profile: light (merit: default light: lines 74<800, files 4<1000000, hunks 4<1000000, no hot path) · policy: below-size-and-path-gates
Roster: B-assert-ctx → gpt-6-sol (openai), B-state → gpt-6-sol (openai), C-assert-xhigh → claude-code-opus-5-5 (anthropic), L6 → gpt-6-sol (openai)

Post-merge review (fleetreview:post-merge override): this reviewed the merge commit against its first parent — the bytes that already shipped. It is not a pre-merge gate pass.

profile: light (rule: default light: lines 74<800, files 4<1000000, hunks 4<1000000, no hot path) · round 0 · members: B-assert-ctx, B-state, L6, C-assert-xhigh · families: anthropic,openai

Confidence: 3/5

Findings

  • P1 plugins/memory/mem0/capture_router.py:573 — Temp-file collision · agreed: B-assert-ctx,B-state,L6,C-assert-xhigh (openai, anthropic)

FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5 · cost: $0.33 · duration: 4m 02s · rounds: 1 · files examined: 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants