Repository navigation
fix(watchdog): per-leaf JSON redaction in describe_call (main red since #1350) - #1378
Conversation
…-then-redact (t_b00e4aa6) tools/tool_wait_watchdog.py:69 (#1350) ran redact_sensitive_text over json.dumps(args), the shape tests/agent/test_redact_json_leaf.py guards against; main has been red on it. Dict args without a descriptive key are now redacted with redact_sensitive_json before serializing; non-JSON leaves go through redact_sensitive_text via json.dumps default=. String paths keep force=True + redact_url_credentials=True. Verified: test_redact_json_leaf.py + test_gateway_foreground_deafness.py 57 passed; the guard test fails on fork/main ab6b6d4 without this change.
FleetReviewBelow the merit threshold, review skipped (43 changed lines < 150 and 1 changed files < 6, no hot path touched; skipped by policy). FleetReview · reviewKind: skipped-by-policy |
|
🤖 merged-by: apollo · lane: review · gate: fleetreview 363d4b0 green · why: t_b00e4aa6: CI green; Apollo review pass 17:18 |
FleetReviewReview: post-merge · head Post-merge review ( profile: light (rule: default light: lines 43<800, files 1<1000000, hunks 1<1000000, no hot path) · round 0 · members: B-assert-ctx, B-state, C-assert-xhigh, G · families: anthropic,openai,xai Confidence: 3/5 Findings
FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, D=grok-4.6 · cost: $0.61 · duration: 5m 21s · rounds: 1 · files examined: 1 |
Fixes main red:
tests/agent/test_redact_json_leaf.py::test_no_serialize_then_redact_text_call_sitesflaggedtools/tool_wait_watchdog.py:69(redact_sensitive_text(json.dumps(args)), from #1350).describe_callnow redacts dict args with no descriptive key viaagent.redact.redact_sensitive_jsonbefore serializing; non-JSON leaves are redacted through thejson.dumpsdefault=hook. String paths unchanged in behavior (force=True, redact_url_credentials=True). Contract test not touched.Verify:
pytest tests/agent/test_redact_json_leaf.py tests/tools/test_gateway_foreground_deafness.py-> 57 passed locally; guard test fails on ab6b6d4 without the change.Kanban: t_b00e4aa6
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.