Skip to content

fix(watchdog): per-leaf JSON redaction in describe_call (main red since #1350) - #1378

Merged
Kyzcreig merged 1 commit into
mainfrom
daedalus/t_b00e4aa6-watchdog-redact-json
Sep 28, 2026
Merged

Kyzcreig merged 1 commit into
mainfrom
daedalus/t_b00e4aa6-watchdog-redact-json

Conversation

@ang-fleet-workers

@ang-fleet-workers ang-fleet-workers Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Fixes main red: tests/agent/test_redact_json_leaf.py::test_no_serialize_then_redact_text_call_sites flagged tools/tool_wait_watchdog.py:69 (redact_sensitive_text(json.dumps(args)), from #1350).

describe_call now redacts dict args with no descriptive key via agent.redact.redact_sensitive_json before serializing; non-JSON leaves are redacted through the json.dumps default= hook. String paths unchanged in behavior (force=True, redact_url_credentials=True). Contract test not touched.

Verify: pytest tests/agent/test_redact_json_leaf.py tests/tools/test_gateway_foreground_deafness.py -> 57 passed locally; guard test fails on ab6b6d4 without the change.

Kanban: t_b00e4aa6


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…-then-redact (t_b00e4aa6)

tools/tool_wait_watchdog.py:69 (#1350) ran redact_sensitive_text over json.dumps(args),
the shape tests/agent/test_redact_json_leaf.py guards against; main has been red on it.
Dict args without a descriptive key are now redacted with redact_sensitive_json before
serializing; non-JSON leaves go through redact_sensitive_text via json.dumps default=.
String paths keep force=True + redact_url_credentials=True.

Verified: test_redact_json_leaf.py + test_gateway_foreground_deafness.py 57 passed;
the guard test fails on fork/main ab6b6d4 without this change.
@ang-prism

ang-prism Bot commented Sep 28, 2026

Copy link
Copy Markdown

FleetReview

Below the merit threshold, review skipped (43 changed lines < 150 and 1 changed files < 6, no hot path touched; skipped by policy).


FleetReview · reviewKind: skipped-by-policy

@Kyzcreig

Copy link
Copy Markdown
Collaborator

🤖 merged-by: apollo · lane: review · gate: fleetreview 363d4b0 green · why: t_b00e4aa6: CI green; Apollo review pass 17:18

@Kyzcreig
Kyzcreig merged commit 24526e1 into main Sep 28, 2026
40 checks passed
@Kyzcreig
Kyzcreig deleted the daedalus/t_b00e4aa6-watchdog-redact-json branch September 28, 2026 00:21
@ang-fleet-ci-actuators ang-fleet-ci-actuators Bot added the fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent) label Sep 28, 2026
@ang-prism

ang-prism Bot commented Sep 28, 2026

Copy link
Copy Markdown

FleetReview

Review: post-merge · head 24526e1ba6fa · duration 5m 23s
Profile: light (merit: default light: lines 43<800, files 1<1000000, hunks 1<1000000, no hot path) · policy: below-size-and-path-gates
Roster: B-assert-ctx → gpt-6-sol (openai), B-state → gpt-6-sol (openai), C-assert-xhigh → claude-code-opus-5-5 (anthropic), G → grok-4.6 (xai)

Post-merge review (fleetreview:post-merge override): this reviewed the merge commit against its first parent — the bytes that already shipped. It is not a pre-merge gate pass.

profile: light (rule: default light: lines 43<800, files 1<1000000, hunks 1<1000000, no hot path) · round 0 · members: B-assert-ctx, B-state, C-assert-xhigh, G · families: anthropic,openai,xai

Confidence: 3/5

Findings

  • P1 tools/tool_wait_watchdog.py:76 — Redaction order · agreed: B-assert-ctx (openai)

FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, D=grok-4.6 · cost: $0.61 · duration: 5m 21s · rounds: 1 · files examined: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant