Repository navigation
fix(moa): neutralize reference_responses tags in reference responses (FleetReview P1, #1353) - #1377
Conversation
…onses (t_931fdc1d) A reference response could emit </reference_responses> plus a forged 'User query:' section and escape the aggregator's data block. Entity-escape any open/close reference_responses tag (case/whitespace/attr variants) in each response before wrapping. Verified: tests/tools/test_mixture_of_agents_prompt_roles.py 2 passed; new test fails against the pre-fix file.
FleetReviewBelow the merit threshold, review skipped (33 changed lines < 150 and 2 changed files < 6, no hot path touched; skipped by policy). FleetReview · reviewKind: skipped-by-policy |
|
🤖 merged-by: apollo · lane: review · gate: fleetreview 48e307f green · why: t_931fdc1d: CI green; Apollo review pass 17:55 |
FleetReviewReview: post-merge · head Post-merge review ( Reviewed with 2 of 3 model families — xai unavailable. profile: light (rule: default light: lines 33<800, files 2<1000000, hunks 4<1000000, no hot path) · round 0 · members: B-assert-ctx, C-assert-xhigh, F, G · families: anthropic,openai Confidence: 4/5 Findings
FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, D=grok-4.6, F=gpt-6-sol · cost: $0.35 · duration: 11m 39s · rounds: 2 · files examined: 2 |
FleetReview P1 on #1353 (key e953813ec984): a reference response could close
<reference_responses>and forge aUser query:section.Fix:
_neutralize_reference_tagsentity-escapes any open/closereference_responsestag (case, whitespace, attribute variants) inside each response before it is wrapped. Content is kept, not dropped.Test:
tests/tools/test_mixture_of_agents_prompt_roles.py. The new test asserts there is exactly one real open/close tag pair and that only the real query follows the close tag. It fails on the pre-fix code and passes after.Card: t_931fdc1d
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.