Skip to content

fix(moa): neutralize reference_responses tags in reference responses (FleetReview P1, #1353) - #1377

Merged
Kyzcreig merged 1 commit into
mainfrom
daedalus/t_931fdc1d-moa-tag-escape
Sep 28, 2026
Merged

Kyzcreig merged 1 commit into
mainfrom
daedalus/t_931fdc1d-moa-tag-escape

Conversation

@ang-fleet-workers

@ang-fleet-workers ang-fleet-workers Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

FleetReview P1 on #1353 (key e953813ec984): a reference response could close <reference_responses> and forge a User query: section.

Fix: _neutralize_reference_tags entity-escapes any open/close reference_responses tag (case, whitespace, attribute variants) inside each response before it is wrapped. Content is kept, not dropped.

Test: tests/tools/test_mixture_of_agents_prompt_roles.py. The new test asserts there is exactly one real open/close tag pair and that only the real query follows the close tag. It fails on the pre-fix code and passes after.

Card: t_931fdc1d


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…onses (t_931fdc1d)

A reference response could emit </reference_responses> plus a forged
'User query:' section and escape the aggregator's data block. Entity-escape
any open/close reference_responses tag (case/whitespace/attr variants) in
each response before wrapping.

Verified: tests/tools/test_mixture_of_agents_prompt_roles.py 2 passed;
new test fails against the pre-fix file.
@ang-prism

ang-prism Bot commented Sep 28, 2026

Copy link
Copy Markdown

FleetReview

Below the merit threshold, review skipped (33 changed lines < 150 and 2 changed files < 6, no hot path touched; skipped by policy).


FleetReview · reviewKind: skipped-by-policy

@ang-fleet-lander

Copy link
Copy Markdown

🤖 merged-by: apollo · lane: kanban-merge-pass · gate: fleetreview 48e307f green · why: t_931fdc1d: FleetReview P1: #1353 @ab6b6d46 tools/mixture_of_agents; Argus off card review (Ace 13:08), CI green

@ang-fleet-lander
ang-fleet-lander Bot added this pull request to the merge queue Sep 28, 2026
@Kyzcreig

Copy link
Copy Markdown
Collaborator

🤖 merged-by: apollo · lane: review · gate: fleetreview 48e307f green · why: t_931fdc1d: CI green; Apollo review pass 17:55

@Kyzcreig
Kyzcreig removed this pull request from the merge queue due to a manual request Sep 28, 2026
@Kyzcreig
Kyzcreig merged commit 7766fcf into main Sep 28, 2026
41 checks passed
@Kyzcreig
Kyzcreig deleted the daedalus/t_931fdc1d-moa-tag-escape branch September 28, 2026 00:56
@ang-fleet-ci-actuators ang-fleet-ci-actuators Bot added the fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent) label Sep 28, 2026
@ang-prism

ang-prism Bot commented Sep 28, 2026

Copy link
Copy Markdown

FleetReview

Review: post-merge · head 7766fcf645c2 · duration 11m 41s
Profile: light (merit: default light: lines 33<800, files 2<1000000, hunks 4<1000000, no hot path) · policy: below-size-and-path-gates
Roster: B-assert-ctx → gpt-6-sol (openai), C-assert-xhigh → claude-code-opus-5-5 (anthropic), F → gpt-6-sol (openai), G → gpt-6-sol (openai)

Post-merge review (fleetreview:post-merge override): this reviewed the merge commit against its first parent — the bytes that already shipped. It is not a pre-merge gate pass.

Reviewed with 2 of 3 model families — xai unavailable.

profile: light (rule: default light: lines 33<800, files 2<1000000, hunks 4<1000000, no hot path) · round 0 · members: B-assert-ctx, C-assert-xhigh, F, G · families: anthropic,openai

Confidence: 4/5

Findings

  • P2 tools/mixture_of_agents_tool.py:91 — Regex slowdown · agreed: B-assert-ctx,C-assert-xhigh (openai, anthropic)

FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, D=grok-4.6, F=gpt-6-sol · cost: $0.35 · duration: 11m 39s · rounds: 2 · files examined: 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant