Repository navigation
feat(kanban): audited --operator send-back on request-changes (t_7481005e) - #1321
Merged
ang-fleet-lander[bot] merged 1 commit intoSep 27, 2026
Merged
Conversation
…005e) #999 retired reopen-review and the dashboard review->ready drag, so an operator bouncing a card for a non-review reason (wrong repo, rebase first) had to fabricate a review_coverage record. request_changes now takes operator="<who: why>" (home-guard #1074 vocabulary): operator profiles only (OPERATOR_PROFILES), coverage waived for that call, an operator_override event (coverage_waived) on the closed run. Reviewer runs keep the coverage gate; the CLI refuses --operator from a dispatched worker run. Wired on the CLI (existing --operator flag) and POST /tasks/{id}/request-changes (operator field). The home guard's own operator_override is deduped so a foreign-card send-back writes one. Verified: tests/.../test_kanban_review_sendback.py 26 passed (10 new); dedupe test fails with the dedupe mutated out. Neighbouring review/home guard suites: 8 failures identical on fork/main without this diff.
ang-fleet-lander
Bot
deleted the
daedalus/t_7481005e-operator-sendback
branch
September 27, 2026 16:41
ang-fleet-ci-actuators
Bot
added
the
fleetreview:post-merge
FleetReviewFleetReview's daily member-call budget is spent (1200/1200 for 2026-09-27 UTC); review skipped. FleetReview · reviewKind: skipped-budget |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card t_7481005e (from operator-capability audit t_674b3ce7, class B).
#999 retired
reopen-reviewand the dashboard review→ready drag (409). An operator bouncing a card for a non-review reason ("wrong repo", "rebase first") had to fabricate a review_coverage record.kanban_db.request_changes(..., operator="<who: why>"): operator profiles only (OPERATOR_PROFILES: default/apollo/aegis), who: why required, coverage waived for that call,operator_overrideevent (action=request-changes,coverage_waived=true) on the closed run;changes_requestedpayload carriesoperator.hermes kanban request-changes <id> <reason> --operator "<who: why>"(flag already existed via the home-guard loop; now also waives coverage). Refused from a dispatched worker run.POST /tasks/{id}/request-changesacceptsoperator; the 409 drag refusal text points at it.record_foreign_actiondedupes so a foreign-card operator send-back writes oneoperator_override.Acceptance (test_kanban_review_sendback.py, 26 passed / 10 new): reviewer run without coverage still refused (and cannot borrow --operator); operator with who: why succeeds + event recorded (kb, CLI, dashboard); non-operator with --operator refused, card untouched. Dedupe test proven by mutation.
Local neighbouring suites: 8 failures (test_kanban_review_surfaces x5, test_kanban_survivor_binding x3) identical on fork/main without this diff; CI is the read.