Repository navigation
revert(discord): drop opt-in raw-reaction journal (#129 DROP, t_d72c6944) - #1273
Merged
Merged
Conversation
Fork-PR audit verdict DROP (lead t_03e35f0e, card t_d72c6944): the journal is written but nothing in the fleet reads it on a schedule. The live journal (~/.hermes/greenhouse/reactions.jsonl) is at seq 40486 on 2026-09-25, so the feature does fire. Its only reader is the manual `seed_triage.py report --journal` in ANG-Ventures/greenhouse-tools (verdict-age column). That tool is not scheduled, and there is no local checkout of it on the Studio. Reverts 56be472. The conflict in adapter.py was resolved by keeping main's seeded_extra/_skip_env_bridge shape and removing the reaction_journal keys. Verified: tests/gateway/test_discord_connect.py plus test_discord_reactions.py give 19 passed and 1 failed. The failure is test_post_connect_initialization_retries_fingerprint_after_timeout, and it fails the same way on fork/main 382fc62.
ang-fleet-ci-actuators
Bot
added
the
fleetreview:post-merge
FleetReviewPost-merge review ( Reviewed with 2 of 3 model families — anthropic unavailable. Confidence: 2/5 Findings
FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, D=grok-4.6, F=gpt-6-sol · cost: $0.51 · duration: 2m 50s · rounds: 2 · files examined: 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card: t_d72c6944. This is a fork-PR audit DROP of #129, confirmed by Ace's ruling on 2026-09-27 00:39 PT. The disposition is recorded in FINAL.md (#1128).
It reverts the opt-in raw-reaction journal from the Discord adapter:
plugins/platforms/discord/adapter.pyloses 133 lines.tests/gateway/test_discord_reaction_journal.pyis deleted.Verification:
git grepfinds noreaction_journal/DISCORD_REACTION_JOURNALreferences outside the audit docs.py_compilepasses.pytest tests/gateway/test_discord_connect.py tests/gateway/test_discord_reactions.pygives 19 passed and 1 failed. The failure istest_free_response_inline_other_bot_mention_reaches_platform_event, and it fails the same way on a cleanorigin/main4511497.Ops half, which Apollo applies at land time: remove
discord.reaction_journalfrom~/.hermes/config.yaml. Once this merges, that key has no reader.Note: one manual reader of the existing
reactions.jsonlfile remains. It isgreenhouse-tools seed_triage.py report --journal, for the verdict-age column. Ace ruled the DROP knowing this.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.