Repository navigation
restore: fork messaging + moa toolsets (revert #1132) — Ace KEEP - #1238
Merged
Merged
Conversation
|
🤖 merged-by: apollo · lane: kanban-merge-pass · gate: BYPASS: FleetReview paused since 09-22; gate = CI green + Apollo diff review · why: restore messaging+moa toolsets (revert #1132, ACE-GATED draft merged without ruling; Ace KEEP 00:5x); exact revert; 31 tests pass |
FleetReviewReview: post-merge · head Post-merge review ( Confidence: 3/5 Findings
FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, D=grok-4.6, F=gpt-6-sol · cost: $3.55 · duration: 12m 00s · rounds: 1 · files examined: 8 |
ang-fleet-workers Bot
added a commit
that referenced
this pull request
Sep 27, 2026
…s (t_9c9e757c) FleetReview retro-backfill 2026-09-27, class C4. Each finding re-verified at 5a9d284; one RED-on-base / GREEN test per confirmed instance. - #813 agent/quota_registry_gate.py: missing/unparseable observed_at now fails open (docstring contract), no longer skips a working fallback. - #1017 cron/lifecycle_guard.py: mask allowlist refuses module callables passed as values (json.dumps(p, default=subprocess.run), sorted(key=...)). - #1019 agent/lsp/manager.py: slot-dir OSError in _has_capacity -> run without LSP instead of raising out of enabled_for()/write_file. - #1026 cron/scheduler.py: owner-deadman exemption scoped to the host it owns; a note naming only another DOWN host is gated. - #1229 scripts/ci/live_comment.py: comment lookup/update network errors no longer kill the poller; a failed post is retried next poll. - #1230 plugins_cmd.py: pinned-plugin remedy shell-quotes the recorded source (CLI + dashboard). - #1238 tools/mixture_of_agents_tool.py: reference responses move from the aggregator system message to a tagged data block in the user message. Verified: test-gate narrow pytest; new tests 13 RED on base, all GREEN with fix; neighbouring suites (lifecycle_guard x4, host_down_gate, quota wiring, plugins_cmd, fallback_policy, fork toolsets) pass.
This was referenced Sep 27, 2026
ang-fleet-workers Bot
added a commit
that referenced
this pull request
Sep 27, 2026
…s (t_9c9e757c) FleetReview retro-backfill 2026-09-27, class C4. Each finding re-verified at 5a9d284; one RED-on-base / GREEN test per confirmed instance. - #813 agent/quota_registry_gate.py: missing/unparseable observed_at now fails open (docstring contract), no longer skips a working fallback. - #1017 cron/lifecycle_guard.py: superseded by #1348 (6662bbd) on main; this slice's 5 callback cases pass against it, so the edit was dropped on rebase. - #1019 agent/lsp/manager.py: slot-dir OSError in _has_capacity -> run without LSP instead of raising out of enabled_for()/write_file. - #1026 cron/scheduler.py: owner-deadman exemption scoped to the host it owns; a note naming only another DOWN host is gated. - #1229 scripts/ci/live_comment.py: comment lookup/update network errors no longer kill the poller; a failed post is retried next poll. - #1230 plugins_cmd.py: pinned-plugin remedy shell-quotes the recorded source (CLI + dashboard). - #1238 tools/mixture_of_agents_tool.py: reference responses move from the aggregator system message to a tagged data block in the user message. Verified: test-gate narrow pytest; new tests 13 RED on base, all GREEN with fix; neighbouring suites (lifecycle_guard x4, host_down_gate, quota wiring, plugins_cmd, fallback_policy, fork toolsets) pass.
Kyzcreig
pushed a commit
that referenced
this pull request
Sep 27, 2026
) * fix(security): Backfill C3 secret/PII exposure class (t_36b0277a) - tools/tool_wait_watchdog: redact tool args (force + URL creds) before the 240-char cut; long-wait log lines carried raw commands/tokens (#1012). - tools/openrouter_client: one client per OpenRouter credential, not per process; a multiplexed gateway sent later profiles' MoA prompts under the first profile's key (#1238). mixture_of_agents_tool uses the scope-aware key check. - plugins/kanban-home-cards: redact URL credentials in card text and redact the board slug, both injected into model context (#968). - agent/fallback_events: persisted err_head redacts URL credentials (#1211). - gateway/run.py: STT INFO line logs size+latency, not the user's words (#1064). - agent/turn_handoff: tool args/results redacted before /resume-handoff (#813). Verified: each new test fails on base and passes on head; test_turn_handoff (34), test_voice_inbound_accounting + test_gateway_foreground_deafness (39), test_kanban_home_cards + test_fallback_events_ledger (101), test_secret_scope_tier1_migration (23 passed, 2 skipped). * test: build fake URL credentials by concatenation (gitleaks generic-api-key) (t_36b0277a) --------- Co-authored-by: ang-fleet-workers[bot] <333956806+ang-fleet-workers[bot]@users.noreply.github.com>
Kyzcreig
pushed a commit
that referenced
this pull request
Sep 27, 2026
…s (t_9c9e757c) (#1353) FleetReview retro-backfill 2026-09-27, class C4. Each finding re-verified at 5a9d284; one RED-on-base / GREEN test per confirmed instance. - #813 agent/quota_registry_gate.py: missing/unparseable observed_at now fails open (docstring contract), no longer skips a working fallback. - #1017 cron/lifecycle_guard.py: superseded by #1348 (6662bbd) on main; this slice's 5 callback cases pass against it, so the edit was dropped on rebase. - #1019 agent/lsp/manager.py: slot-dir OSError in _has_capacity -> run without LSP instead of raising out of enabled_for()/write_file. - #1026 cron/scheduler.py: owner-deadman exemption scoped to the host it owns; a note naming only another DOWN host is gated. - #1229 scripts/ci/live_comment.py: comment lookup/update network errors no longer kill the poller; a failed post is retried next poll. - #1230 plugins_cmd.py: pinned-plugin remedy shell-quotes the recorded source (CLI + dashboard). - #1238 tools/mixture_of_agents_tool.py: reference responses move from the aggregator system message to a tagged data block in the user message. Verified: test-gate narrow pytest; new tests 13 RED on base, all GREEN with fix; neighbouring suites (lifecycle_guard x4, host_down_gate, quota wiring, plugins_cmd, fallback_policy, fork toolsets) pass. Co-authored-by: ang-fleet-workers[bot] <333956806+ang-fleet-workers[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1132 exactly (restores
send_messagemessaging toolset,mixture_of_agentstool + moa toolset, and the fork canary testtests/agent/test_fork_custom_toolsets.py).Why: #1132 was marked ACE-GATED — DRAFT, DO NOT MERGE (fork-features registry entry 4 is
fork-permanent). It was merged 2026-09-26 07:23Z by a sweep lane without Ace's ruling. Ace's ruling (00:5x PT): keep these toolsets. Registry entry 4 stays fork-permanent.Local:
tests/agent/test_fork_custom_toolsets.py tests/test_toolsets.py→ 31 passed.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.