Skip to content

revert(mem0): drop #251 correction-marker salience-gate bypass (fork-PR audit DROP) - #1213

Merged
ang-fleet-lander[bot] merged 5 commits into
mainfrom
audit/plugins/revert-251-v2
Sep 26, 2026
Merged

ang-fleet-lander[bot] merged 5 commits into
mainfrom
audit/plugins/revert-251-v2

Conversation

@Kyzcreig

Copy link
Copy Markdown
Collaborator

Fork-PR audit DROP for #251 (card t_ff91a776; lead t_03e35f0e FINAL DROP; FINAL.md row in docs PR #1128).

Reverts c7d49c9 "mem0: bypass salience gate for corrections (#251)". Rationale from the audit: 0 own log lines in production; the 7 loose "correction" hits are not this gate (adv KEEP-UNPROVEN, auditor KEEP weak).

Conflict resolution (later work kept intact):

Local narrow verification:

  • pytest plugins/memory/mem0/test_capture_router.py test_capture_drain.py test_capture_pipeline.py -> 53 passed
  • pytest tests/plugins/memory/test_mem0_thread_lifecycle.py -> 5 passed
  • ruff check on the 4 files -> clean
  • grep for correction_marker|corrections_detected|existing_fact_lookup|correction_detected in plugins/ tests/ -> 0 hits

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Replaces #1161 (its head branch rejects pushes, so the fork/main merge that resolves the test_capture_router.py conflict with #1119 could not land there). Resolution: main's #1119 cooldown tests kept, #251 correction tests dropped. Narrow run: plugins/memory/mem0/test_capture_router.py 26 passed. Card t_ff91a776, campaign t_f201acde.

…PR audit DROP)

This reverts commit c7d49c9 (#251). Fork-PR audit lead t_03e35f0e ruled
FINAL DROP (FINAL.md row, docs PR #1128): 0 own log lines in production; the
7 loose "correction" log hits are not this gate.

Conflicts resolved against later work: kept #407's transient-narration gate
(transient_filter_enabled, transient_dropped stat) and #652's
fallback-model test; removed only #251's correction_markers,
existing_fact_lookup_fn, corrections_detected, contradiction signals and
drain precompute/bypass.

Verified: pytest plugins/memory/mem0/test_capture_router.py
test_capture_drain.py test_capture_pipeline.py -> 53 passed;
tests/plugins/memory/test_mem0_thread_lifecycle.py -> 5 passed; ruff clean.

Card: t_ff91a776
# Conflicts:
#	plugins/memory/mem0/test_capture_router.py
@blacksmith-sh

blacksmith-sh Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
TestPinTransition/test_cache_busting_signature_reflects_pin_peer_name View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Conflict in capture_router.py: main reverted #407 (transient gate); resolved
to main's #407-free shape minus #251. grep for #251/#407 symbols -> 0 hits.
Verified: mem0 capture tests 59 passed; tests/honcho_plugin/test_pin_peer_name.py 26 passed.
…n bypass

The revert removes capture_correction / correction-marker bypass code; the
README still documented it. Verified: git grep capture_correction|correction_marker
outside docs/plans -> 0 hits; test_capture_router.py 26 passed.
@ang-fleet-lander

Copy link
Copy Markdown

🤖 merged-by: apollo · lane: alerts-sweep · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: fork-PR audit DROP #251 (t_ff91a776, lead t_03e35f0e FINAL DROP): clean revert +44/-476 of c7d49c9 keeping #407 transient gate; 0 own log lines in production; CI green; not in the 9 ACE-GATED DROPs

@ang-fleet-lander
ang-fleet-lander Bot added this pull request to the merge queue Sep 26, 2026
Merged via the queue into main with commit f36243f Sep 26, 2026
42 checks passed
@ang-fleet-lander
ang-fleet-lander Bot deleted the audit/plugins/revert-251-v2 branch September 26, 2026 15:16
@ang-prism

ang-prism Bot commented Sep 27, 2026

Copy link
Copy Markdown

FleetReview

Review: post-merge · head f36243fec66e · duration 9m 12s
Profile: light (merit: default light: lines 520<1000000, files 5<1000000, hunks 25<1000000, no hot path) · policy: changed-lines>400
Roster: B-assert-ctx → gpt-6-sol (openai), C-assert-xhigh → claude-code-opus-5-5 (anthropic), F → gpt-6-sol (openai), G → grok-4.6 (xai)

Post-merge review (fleetreview:post-merge override): this reviewed the merge commit against its first parent — the bytes that already shipped. It is not a pre-merge gate pass.

profile: light (rule: default light: lines 520<1000000, files 5<1000000, hunks 25<1000000, no hot path) · round 0 · members: B-assert-ctx, C-assert-xhigh, F, G · families: anthropic,openai,xai

Confidence: 2/5

Findings

  • P1 plugins/memory/mem0/capture_drain.py:346 — Lost corrections · agreed: B-assert-ctx,C-assert-xhigh,F (openai, anthropic)
  • P1 plugins/memory/mem0/capture_router.py:441 — Incompatible caller · agreed: B-assert-ctx,F,G (openai, xai)
  • P1 plugins/memory/mem0/capture_router.py:9 — Corrections dropped · agreed: B-assert-ctx,G (openai, xai)
  • P1 plugins/memory/mem0/capture_drain.py:430 — Newly activated router can persist secrets without the capture scrub · agreed: F,G (openai, xai)
  • P1 plugins/memory/mem0/capture_drain.py:416 — A crash after mem0 add can permanently skip world/event routing · agreed: F (openai)

FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, D=grok-4.6, F=gpt-6-sol · cost: $2.02 · duration: 9m 08s · rounds: 1 · files examined: 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant