Repository navigation
revert(mem0): drop #251 correction-marker salience-gate bypass (fork-PR audit DROP) - #1213
Conversation
…PR audit DROP) This reverts commit c7d49c9 (#251). Fork-PR audit lead t_03e35f0e ruled FINAL DROP (FINAL.md row, docs PR #1128): 0 own log lines in production; the 7 loose "correction" log hits are not this gate. Conflicts resolved against later work: kept #407's transient-narration gate (transient_filter_enabled, transient_dropped stat) and #652's fallback-model test; removed only #251's correction_markers, existing_fact_lookup_fn, corrections_detected, contradiction signals and drain precompute/bypass. Verified: pytest plugins/memory/mem0/test_capture_router.py test_capture_drain.py test_capture_pipeline.py -> 53 passed; tests/plugins/memory/test_mem0_thread_lifecycle.py -> 5 passed; ruff clean. Card: t_ff91a776
# Conflicts: # plugins/memory/mem0/test_capture_router.py
|
Found 1 test failure on Blacksmith runners: Failure
|
…n bypass The revert removes capture_correction / correction-marker bypass code; the README still documented it. Verified: git grep capture_correction|correction_marker outside docs/plans -> 0 hits; test_capture_router.py 26 passed.
|
🤖 merged-by: apollo · lane: alerts-sweep · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: fork-PR audit DROP #251 (t_ff91a776, lead t_03e35f0e FINAL DROP): clean revert +44/-476 of c7d49c9 keeping #407 transient gate; 0 own log lines in production; CI green; not in the 9 ACE-GATED DROPs |
FleetReviewReview: post-merge · head Post-merge review ( profile: light (rule: default light: lines 520<1000000, files 5<1000000, hunks 25<1000000, no hot path) · round 0 · members: B-assert-ctx, C-assert-xhigh, F, G · families: anthropic,openai,xai Confidence: 2/5 Findings
FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, D=grok-4.6, F=gpt-6-sol · cost: $2.02 · duration: 9m 08s · rounds: 1 · files examined: 5 |
…ging or inbox write (C3 #1213)
Fork-PR audit DROP for #251 (card t_ff91a776; lead t_03e35f0e FINAL DROP; FINAL.md row in docs PR #1128).
Reverts c7d49c9 "mem0: bypass salience gate for corrections (#251)". Rationale from the audit: 0 own log lines in production; the 7 loose "correction" hits are not this gate (adv KEEP-UNPROVEN, auditor KEEP weak).
Conflict resolution (later work kept intact):
transient_filter_enabled,transient_droppedstat); removed mem0: bypass salience gate for corrections #251'scorrection_markers,existing_fact_lookup_fn,corrections_detected, contradiction signals.test_build_router_fallback_model_never_inherits_primary_id; removed mem0: bypass salience gate for corrections #251's correction-marker test.Local narrow verification:
pytest plugins/memory/mem0/test_capture_router.py test_capture_drain.py test_capture_pipeline.py-> 53 passedpytest tests/plugins/memory/test_mem0_thread_lifecycle.py-> 5 passedruff checkon the 4 files -> cleancorrection_marker|corrections_detected|existing_fact_lookup|correction_detectedin plugins/ tests/ -> 0 hitsNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Replaces #1161 (its head branch rejects pushes, so the fork/main merge that resolves the test_capture_router.py conflict with #1119 could not land there). Resolution: main's #1119 cooldown tests kept, #251 correction tests dropped. Narrow run: plugins/memory/mem0/test_capture_router.py 26 passed. Card t_ff91a776, campaign t_f201acde.