revert(desktop): drop the fork-only session.pin RPC (#186 server half) - #1153
Merged
Merged
Conversation
Kyzcreig
force-pushed
the
audit/agent/revert-pr186
branch
from
September 25, 2026 23:13
c1d6e31 to
9b4fafe
Compare
|
🤖 merged-by: apollo · lane: kanban-merge-pass · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: t_9390d8c0: fork-PR audit DROP: #186 fix(desktop): server-side pinned sessions; Argus off card review (Ace 13:08), CI green |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 26, 2026
Kyzcreig
force-pushed
the
audit/agent/revert-pr186
branch
from
September 26, 2026 06:58
9b4fafe to
77d97ac
Compare
This comment has been minimized.
This comment has been minimized.
Partial revert of 0df54d7 (audit t_712c13f2, DROP, D9 mixed desktop row): only the server half is in scope; apps/desktop is taken from upstream at sync. Of #186's server half, hermes_state.set_session_pinned / include_pinned and the web_server pinned PATCH are now upstream's own (hermes_state_sessions.py:952, web_routers/sessions.py:755 on upstream/main; fork callers sessions_cmd.py, web_routers/profiles.py, api_server.py, prune tests depend on them) — not revertable, superseded-by-upstream. The only fork-only remnant is the tui_gateway session.pin JSON-RPC method + its 3 tests. _session_live_pinned stays: session.info/session.list 'pinned' is in upstream's contract (tui_gateway/contracts/common.py:122). Verified: test-gate pytest tests/test_tui_gateway_server.py -> 669 passed.
Kyzcreig
force-pushed
the
audit/agent/revert-pr186
branch
from
September 26, 2026 07:04
77d97ac to
07fc4b9
Compare
|
🤖 merged-by: apollo · lane: kanban-merge-pass · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: t_9390d8c0: fork-PR audit DROP: #186 fix(desktop): server-side pinned sessions; Argus off card review (Ace 13:08), CI green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-PR audit DROP for #186 (card t_9390d8c0, lead t_03e35f0e, FINAL.md row in docs PR #1128).
Removes only the fork-only
session.pinJSON-RPC method in tui_gateway/server.py and its 3 tests. The rest of #186's server half (set_session_pinned / include_pinned, pinned PATCH) is now upstream's own and stays._session_live_pinnedstays (upstream contract, tui_gateway/contracts/common.py). No remaining callers ofsession.pinin apps/desktop, ui-tui or tui_gateway (grep).Verify:
pytest tests/test_tui_gateway_server.py-> 669 passed (rebased on main 382fc62).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.