Repository navigation
revert(tui_gateway): drop message.complete committed-id stamping (#352) - #1149
Conversation
Fork-PR audit FINAL DROP (card t_46cf57ba, lead t_03e35f0e, FINAL.md row #352). #352 shipped payload.message_ids on message.complete so the desktop live-sync poll could stamp optimistic rows. The livesync seam is being reverted (#268/#272, audit/scripts_misc/revert-livesync) and the apps/ consumer is already DROP by D9; no fork consumer of message_ids remains (git grep apps/ ui-tui/ web/: 0 hits) and upstream never emitted it. Removes _completed_turn_committed_ids(), its call under history_lock, the payload field, and tests/tui_gateway/test_completed_turn_committed_ids.py. Verified: test-gate narrow run test_failed_turn_retention.py + test_desktop_runtime_footer.py + test_server_no_duplicate_defs.py: 29 passed.
e109c75 to
47dacea
Compare
|
🤖 merged-by: apollo · lane: kanban-merge-pass · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: t_46cf57ba: fork-PR audit DROP: #352 fix(desktop): stop live-sync duplicating every message ; Argus off card review (Ace 13:08), CI green |
|
🤖 merged-by: daedalus-opus · lane: t_f201acde · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: fork-PR audit DROP (Ace ruling 1A, campaign t_03e35f0e, card t_46cf57ba): revert-#352; PR CI green on head; conflict-free vs fork/main + sibling reverts (merge-tree chain) |
Kyzcreig
added
the
fleetreview:post-merge
FleetReviewBelow the merit threshold, review skipped (82 changed lines < 150 and 1 changed files < 6, no hot path touched; skipped by policy). FleetReview · reviewKind: skipped-by-policy |
1 participant
Fork-PR audit FINAL DROP for #352 (card t_46cf57ba; lead t_03e35f0e; FINAL.md in docs PR #1128).
Server half of #352: payload.message_ids on message.complete, used only by the desktop live-sync optimistic-row stamping. The livesync seam goes with the revert-livesync branch (#268/#272, audit/scripts_misc/revert-livesync); the apps/ half is already DROP by D9. No remaining fork consumer (git grep message_ids in apps/ ui-tui/ web/: 0 hits); upstream/main never emits it.
Removes _completed_turn_committed_ids(), its call, the payload field, and its test file. -129 lines, 2 files.
Sequencing: intended to land after revert-livesync; git merge-tree against that branch is clean, so order is not load-bearing.
Verify: test-gate narrow run (test_failed_turn_retention.py, test_desktop_runtime_footer.py, test_server_no_duplicate_defs.py): 29 passed. Registry D2b: none.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.