Skip to content

revert(budget): drop grace-turn side-effect lockout (#37) - #1145

Merged
ang-fleet-lander[bot] merged 1 commit into
mainfrom
audit/agent/revert-37
Sep 26, 2026
Merged

ang-fleet-lander[bot] merged 1 commit into
mainfrom
audit/agent/revert-37

Conversation

@Kyzcreig

@Kyzcreig Kyzcreig commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Fork-PR audit DROP for #37 (card t_0973b125, lead t_03e35f0e, FINAL.md row in docs PR #1128).

Evidence for drop: 0 grace-turn denials in 555,617 turn_tool_calls (06-11..09-25).

Changes:

  • delete agent/budget_grace_gate.py and tests/agent/test_budget_grace_gate.py
  • cut the grace branch from agent/fork_ext/tool_gate.py (scope block path unchanged)
  • remove _in_budget_grace from agent_init / conversation_loop (upstream _budget_grace_call grace turn untouched)
  • tool_executor block ladder: drop grace_block_result special case
  • tests/golden/tool_gate: corpus drops the 2 grace=true cases and _in_budget_grace attrs; runner adapter branch removed; golden.json regenerated (10 cases)
  • Registry D2b entry 11 (tool_gate): paths unchanged and still valid; no registry edit needed

Local verify: refactor_equiv verify on tests/golden/tool_gate rc=0; narrow pytest 27 passed (guardrail runtime, tool_search scoping, TestBudgetPressure, delegate_toolset_scope, test_refactor_equiv).


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Fork-PR audit DROP (lead t_03e35f0e, FINAL.md docs PR #1128): 0 grace-turn
denials in 555,617 turn_tool_calls (06-11..09-25).

- delete agent/budget_grace_gate.py + tests/agent/test_budget_grace_gate.py
- cut the grace branch from agent/fork_ext/tool_gate.py
  pre_tool_block_from_builtin_gate (scope block unchanged)
- drop _in_budget_grace from agent_init / conversation_loop; the upstream
  _budget_grace_call grace turn itself is untouched
- tool_executor: drop grace_block_result special case in the block ladder
- tests/golden/tool_gate: remove the 2 grace=true cases and the
  _in_budget_grace agent attrs from corpus, runner adapter branch removed,
  golden.json regenerated (10 cases)

Registry D2b entry 11 (tool_gate): paths agent/fork_ext/tool_gate.py and
tests/golden/tool_gate/ still exist; no registry edit needed.

Verified: refactor_equiv verify tool_gate golden rc=0; narrow pytest
(guardrail runtime, tool_search scoping, TestBudgetPressure,
delegate_toolset_scope, test_refactor_equiv) 27 passed via test-gate.
@ang-fleet-lander

Copy link
Copy Markdown

🤖 merged-by: apollo · lane: kanban-merge-pass · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: t_0973b125: fork-PR audit DROP: #37 feat(budget): deny-by-default side-effect lockout on the; Argus off card review (Ace 13:08), CI green

@ang-fleet-lander
ang-fleet-lander Bot added this pull request to the merge queue Sep 25, 2026
@ang-fleet-lander

Copy link
Copy Markdown

🤖 merged-by: daedalus-opus · lane: t_f201acde · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: fork-PR audit DROP (Ace ruling 1A, campaign t_03e35f0e, card t_0973b125): revert-#37; PR CI green on head; conflict-free vs fork/main + sibling reverts (merge-tree chain)

Merged via the queue into main with commit 1355818 Sep 26, 2026
56 checks passed
@ang-fleet-lander
ang-fleet-lander Bot deleted the audit/agent/revert-37 branch September 26, 2026 05:01
@Kyzcreig Kyzcreig added the fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent) label Sep 26, 2026
@ang-prism

ang-prism Bot commented Sep 26, 2026

Copy link
Copy Markdown

FleetReview

PARTIAL — ensemble escalated: judge unavailable: every scorer route failed on transport

This review did not reach a trusted verdict, so it is not a gate pass and the findings below may be incomplete. They are posted so they can be read rather than lost in a terminal record.

Post-merge review (fleetreview:post-merge override): this reviewed the merge commit against its first parent — the bytes that already shipped. It is not a pre-merge gate pass.

Reviewed with 2 of 3 model families — openai unavailable.

Confidence: 1/5

Findings

  • P1 agent/fork_ext/tool_gate.py:80 — Grace gate removed
  • P2 tests/agent/test_budget_grace_gate.py:1 — Tests deleted
  • P1 agent/conversation_loop.py:2652 — Grace-turn tool bypass

FleetReview provenance · models: C=claude-code-opus-5-5, D=grok-4.6 · cost: $0.57 · duration: 7m 41s · rounds: 1 · files examined: 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant