BCP-006-01: Test suites for NMOS With JPEG XS #715
Conversation
| 'connectable': True, 'registered': True}] | ||
|
|
||
| # Randomly select some Receivers to be JPEG XS capable | ||
| jxsv_receivers = self._generate_random_indices(len(self.receivers), min_index_count=1) |
There was a problem hiding this comment.
I think it would make sense to remove the defaults from this function, or express the defaults as proportions of the index_range passed in (50%, 100%, maybe, or 25%, 75%?)
def _generate_random_indices(self, index_range, min_index_count=2, max_index_count=4)
There was a problem hiding this comment.
The reasoning for an explicit count rather than a proportion is for the case of testing pagination where the test specifies 2 results per page, and a minimum of 3 to force more than one page. Proportional percentages would be cumbersome in that context, I feel.
Reviewing the use of this function in the IS-04 and IS-05 tests, I'm not sure the max_index_count is needed - I will experiment with removing it. Also the min_index_count should default to 1, and then be overridden in the cases where a minimum needs to be specified to force pagination.
…oller" test suites
Report UNCLEAR 'Could Not Test' if there aren't any video/jxsv Flows
Starting a PR to address #714...