Pull schemas from external Git repo #572
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pulled in by service-api and we don't want a version conflict.
I want to implement notify/v2 for the git server and that requires synchronising with the API.
The path-matching syntax has changed. It's no longer possible to match all the tail of the URL.
These are equivalent to the native git-hooks mechanism but configurable through the ConfigDB. For now at least hooks must be implemented within the git server.
This gives a force-rerun strategy: remove and recreate the hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements pulling schema definitions from an external Git repo. It does this by adding a branch hooks facility to the Git server, meaning the schema loading logic must be implemented inside that service.
The alternative would be to make this a separate service, tracking the repos using change-notify. Such a service would have to track its own state in the ConfigDB and seems a bit overkill for this use case.