Edge Sync updates #561
Draft
Edge Sync updates #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrc-benmorrow
force-pushed
the
bmz/auth-rx-client
branch
3 times, most recently
from
6f309a5 to
307027e
Compare
This doesn't use the Auth service but is suffering from unreliable ConfigDB updates.
If we're committing it we need to build with it.
We started using merge-patch to avoid stomping on status changes made by Flux, but it's not straightforward to use merge-patch to remove fields. Use apply-patch instead, it's what k8s recommend. Unify the handling of the GitRepo resources with the HelmReleases. Give the GitRepo resources more sensible names.
Annoyingly the API has changes. We must maintain back-compat in rx-util for now as this is also used by the Monitor.
amrc-benmorrow
force-pushed
the
bmz/auth-rx-client
branch
from
cc1fb6b to
7688799
Compare
amrc-benmorrow
force-pushed
the
bmz/edge-sync
branch
from
e933387 to
0650e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge-patch will not delete fields. This is the only reliable method of update and is recommended by the k8s docs.
This will redeploy edge deployments when the Helm chart template changes.
The update is incompatible.