Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant/ambiguous information in amici::Model #2573

Open
dweindl opened this issue Nov 8, 2024 · 0 comments
Open

Redundant/ambiguous information in amici::Model #2573

dweindl opened this issue Nov 8, 2024 · 0 comments

Comments

@dweindl
Copy link
Member

dweindl commented Nov 8, 2024

Currently, amici::Model::state_ and amici::Model::simulation_parameters_ both contain fixed_parameters and plist. Those values aren't synced. amici::Model::simulation_parameters_ is initialized during construction and never updated. Setters will only update amici::Model::state_.

This is confusing and likely to cause trouble at some point, and thus, should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant