Skip to content

fix(types): suppress mypy false-positive on HIP-gated cascade call #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
demandal25 merged 2 commits into from
May 20, 2026
Merged

fix(types): suppress mypy false-positive on HIP-gated cascade call #236

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4e8193
fix(types): suppress mypy false-positive on HIP-gated cascade call
demandal25 May 20, 2026
92d969f
Merge branch 'amd-integration' into fix-ci-pre-commit-and-docs
demandal25 May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion flashinfer/cascade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,10 @@ def run(
)
for wrapper in self._batch_prefill_wrappers[:-1]:
if _HIP_FUSED_CASCADE:
out, lse = wrapper.run(
# mypy sees prefill.py (CUDA) wrapper here; at runtime on HIP,
# flashinfer.__init__ aliases sys.modules["flashinfer.prefill"]
# to prefill_rocm, whose run() accepts partial_state.
out, lse = wrapper.run( # type: ignore[call-overload]
q, paged_kv_cache, return_lse=True, partial_state=(out, lse)
)
else:
Expand Down
Loading