Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add render_mode to examples in README to make them work again #91

Merged
merged 2 commits into from
Dec 22, 2023
Merged

add render_mode to examples in README to make them work again #91

merged 2 commits into from
Dec 22, 2023

Conversation

JuliusJacobitz
Copy link
Contributor

@JuliusJacobitz JuliusJacobitz commented Dec 7, 2023 •
edited
Loading 

gym.make('metaworld_ProDMP/reach-v2', render_mode="human")

still does not work somehow

D-o-d-o-x
D-o-d-o-x approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@D-o-d-o-x D-o-d-o-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.
The way we called .render() was also not according to spec. Added a commit to address that.
Should all be fixed now.

Thanks for the PR.

@D-o-d-o-x
Copy link
Collaborator

The issue with metaworld will be addressed with #92.

@Onur4229 Onur4229 merged commit fa54dbb into ALRhub:master Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D-o-d-o-x D-o-d-o-x D-o-d-o-x approved these changes

@Onur4229 Onur4229 Onur4229 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuliusJacobitz @D-o-d-o-x @Onur4229