-
Notifications
You must be signed in to change notification settings - Fork 500
Updates installation page organization and contents #3542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,10 @@ | ||
| ```{include} ../CONTRIBUTING.md | ||
| ``` | ||
|
|
||
| ## Contribute to documentation | ||
|
|
||
| The MaxText documentation website is built using [Sphinx](https://www.sphinx-doc.org) and [MyST](https://myst-parser.readthedocs.io/en/latest/). Documents are written in [MyST Markdown syntax](https://myst-parser.readthedocs.io/en/latest/syntax/typography.html#syntax-core). | ||
|
|
||
| ### Building the documentation locally (optional) | ||
|
|
||
| If you are writing documentation for MaxText, you may want to preview the documentation site locally to ensure things work as expected before a deployment to Read The Docs. | ||
|
|
||
| First, make sure you install the necessary dependencies. You can do this by navigating to your local clone of the MaxText repo and running: | ||
|
|
||
| ```bash | ||
| pip install -r src/dependencies/requirements/requirements_docs.txt | ||
| ``` | ||
|
|
||
| Once the dependencies are installed, you can navigate to the `docs/` folder and run: | ||
|
|
||
| ```bash | ||
| sphinx-build -b html . _build/html | ||
| ```{toctree} | ||
| --- | ||
| hidden: | ||
| --- | ||
| development/update_dependencies.md | ||
| development/contribute_docs.md | ||
| ``` | ||
|
|
||
| This will generate the documentation in the `docs/_build/html` directory. These files can be opened in a web browser directly, or you can use a simple HTTP server to serve the files. For example, you can run: | ||
|
|
||
| ```bash | ||
| python -m http.server -d _build/html | ||
| ``` | ||
|
|
||
| Then, open your web browser and navigate to `http://localhost:8000` to view the documentation. | ||
|
|
||
| ### Adding new documentation files | ||
|
|
||
| If you are adding a new document, make sure it is included in the `toctree` directive corresponding to the section where the new document should live. For example, if adding a new tutorial, make sure it is listed in [the `docs/tutorials.md`](https://github.com/AI-Hypercomputer/maxtext/blob/7070e8eecbea8951c8e5281219ce797c8df1441f/docs/tutorials.md?plain=1#L38). | ||
|
|
||
| ### Documentation deployment | ||
|
|
||
| The MaxText documentation is deployed to [https://maxtext.readthedocs.io](https://maxtext.readthedocs.io) on any successful merge to the main branch. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <!-- | ||
| # Copyright 2023–2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| --> | ||
|
|
||
| # Contribute to documentation | ||
|
|
||
| The MaxText documentation website is built using [Sphinx](https://www.sphinx-doc.org) and [MyST](https://myst-parser.readthedocs.io/en/latest/). Documents are written in [MyST Markdown syntax](https://myst-parser.readthedocs.io/en/latest/syntax/typography.html#syntax-core). | ||
|
|
||
| ## Building the documentation locally (optional) | ||
|
|
||
| If you are writing documentation for MaxText, you may want to preview the documentation site locally to ensure things work as expected before a deployment to Read The Docs. | ||
|
|
||
| First, make sure you install the necessary dependencies. You can do this by navigating to your local clone of the MaxText repo and running: | ||
|
|
||
| ```bash | ||
| pip install -r src/dependencies/requirements/requirements_docs.txt | ||
| ``` | ||
|
|
||
| Once the dependencies are installed, you can navigate to the `docs/` folder and run: | ||
|
|
||
| ```bash | ||
| sphinx-build -b html . _build/html | ||
| ``` | ||
|
|
||
| This will generate the documentation in the `docs/_build/html` directory. These files can be opened in a web browser directly, or you can use a simple HTTP server to serve the files. For example, you can run: | ||
|
|
||
| ```bash | ||
| python -m http.server -d _build/html | ||
| ``` | ||
|
|
||
| Then, open your web browser and navigate to `http://localhost:8000` to view the documentation. | ||
|
|
||
| ## Adding new documentation files | ||
|
|
||
| If you are adding a new document, make sure it is included in the `toctree` directive corresponding to the section where the new document should live. For example, if adding a new tutorial, make sure it is listed in [the `docs/tutorials.md`](https://github.com/AI-Hypercomputer/maxtext/blob/7070e8eecbea8951c8e5281219ce797c8df1441f/docs/tutorials.md?plain=1#L38) toctree. | ||
|
|
||
| ## Documentation deployment | ||
|
|
||
| The MaxText documentation is deployed to [https://maxtext.readthedocs.io](https://maxtext.readthedocs.io) on any successful merge to the main branch. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| <!-- | ||
| # Copyright 2023–2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| --> | ||
|
|
||
| # Update MaxText dependencies | ||
|
|
||
| ## Introduction | ||
|
|
||
| This document provides a guide to updating dependencies in MaxText using the `seed-env` tool. `seed-env` helps generate deterministic and reproducible Python environments by creating fully-pinned `requirements.txt` files from a base set of requirements. | ||
|
|
||
| Please keep dependencies updated throughout development. This will allow each commit to work properly from both a feature and dependency perspective. We will periodically upload commits to PyPI for stable releases. But it is also critical to keep dependencies in sync for users installing MaxText from source. | ||
|
|
||
| ## Overview of the Process | ||
|
|
||
| To update dependencies, you will follow these general steps: | ||
|
|
||
| 1. **Modify Base Requirements**: Update the desired dependencies in `base_requirements/requirements.txt` or the hardware-specific files (`base_requirements/tpu-base-requirements.txt`, `base_requirements/gpu-base-requirements.txt`). | ||
| 2. **Generate New Files**: Run the `seed-env` CLI tool to generate new, fully-pinned requirements files based on your changes. | ||
| 3. **Update Project Files**: Copy the newly generated files into the `generated_requirements/` directory. | ||
| 4. **Handle GitHub Dependencies**: Move any dependencies that are installed directly from GitHub from the generated files to `src/install_maxtext_extra_deps/extra_deps_from_github.txt`. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry - I did not update this page, just moved it from the installation page. Will make sure to review in my next commit. |
||
| 5. **Verify**: Test the new dependencies to ensure the project installs and runs correctly. | ||
|
|
||
| The following sections provide detailed instructions for each step. | ||
|
|
||
| ## Step 1: Install seed-env | ||
|
|
||
| First, you need to install the `seed-env` command-line tool by running `pip install seed-env uv`. Or follow the instructions in the | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In another doc in this PR you commented that
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry - I did not update this page, just moved it from the installation page. Will make sure to review in my next commit. |
||
| [seed-env repository](https://github.com/google-ml-infra/actions/tree/main/python_seed_env#install-the-seed-env-tool) if you want to build `seed-env` from source. | ||
|
|
||
| ## Step 2: Find the JAX Build Commit Hash | ||
|
|
||
| The dependency generation process is pinned to a specific nightly build of JAX. You need to find the commit hash for the desired JAX build. | ||
|
|
||
| You can find the latest commit hashes in the [JAX `build/` folder](https://github.com/jax-ml/jax/commits/main/build). Choose a recent, successful build and copy its full commit hash. | ||
|
|
||
| ## Step 3: Generate the Requirements Files | ||
|
|
||
| Next, run the `seed-env` CLI to generate the new requirements files. You will need to do this separately for the TPU and GPU environments. The generated files will be placed in a directory specified by `--output-dir`. | ||
|
|
||
| ### For TPU | ||
|
|
||
| Run the following command, replacing `<jax-build-commit-hash>` with the hash you copied in the previous step. | ||
|
|
||
| ```bash | ||
| seed-env \ | ||
| --local-requirements=src/dependencies/requirements/base_requirements/tpu-base-requirements.txt \ | ||
| --host-name=MaxText \ | ||
| --seed-commit=<jax-build-commit-hash> \ | ||
| --python-version=3.12 \ | ||
| --requirements-txt=tpu-requirements.txt \ | ||
| --output-dir=generated_tpu_artifacts | ||
| ``` | ||
|
|
||
| ### For GPU | ||
|
|
||
| Similarly, run the command for the GPU requirements. | ||
|
|
||
| ```bash | ||
| seed-env \ | ||
| --local-requirements=src/dependencies/requirements/base_requirements/cuda12-base-requirements.txt \ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: |
||
| --host-name=MaxText \ | ||
| --seed-commit=<jax-build-commit-hash> \ | ||
| --python-version=3.12 \ | ||
| --requirements-txt=cuda12-requirements.txt \ | ||
| --hardware=cuda12 \ | ||
| --output-dir=generated_gpu_artifacts | ||
| ``` | ||
|
|
||
| ## Step 4: Update Project Files | ||
|
|
||
| After generating the new requirements, you need to update the files in the MaxText repository. | ||
|
|
||
| 1. **Copy the generated files:** | ||
|
|
||
| - Move `generated_tpu_artifacts/tpu-requirements.txt` to `generated_requirements/tpu-requirements.txt`. | ||
| - Move `generated_gpu_artifacts/cuda12-requirements.txt` to `generated_requirements/cuda12-requirements.txt`. | ||
|
|
||
| 2. **Update `extra_deps_from_github.txt` (if necessary):** | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above. |
||
| Currently, MaxText uses a few dependencies, such as `mlperf-logging` and `google-jetstream`, that are installed directly from GitHub source. These are defined in `base_requirements/requirements.txt`, and the `seed-env` tool will carry them over to the generated requirements files. | ||
|
|
||
| ## Step 5: Verify the New Dependencies | ||
|
|
||
| Finally, test that the new dependencies install correctly and that MaxText runs as expected. | ||
|
|
||
| 1. **Create a clean environment:** It's best to start with a fresh Python virtual environment. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove installation steps ( |
||
|
|
||
| ```bash | ||
| uv venv --python 3.12 --seed maxtext_venv | ||
| source maxtext_venv/bin/activate | ||
| ``` | ||
|
|
||
| 2. **Run the setup script:** Execute `bash setup.sh` to install the new dependencies. | ||
|
|
||
| ```bash | ||
| # install the tpu package | ||
| uv pip install -e .[tpu] --resolution=lowest | ||
| # or install the gpu package by running the following line: | ||
| # uv pip install -e .[cuda12] --resolution=lowest | ||
| install_maxtext_github_deps | ||
| ``` | ||
|
|
||
| 3. **Run tests:** Run MaxText tests to ensure there are no regressions. | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change
src/install_maxtext_extra_deps/extra_deps_from_github.txttosrc/dependencies/github_deps