Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ckpt conversion scripts #25

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Update ckpt conversion scripts #25

merged 1 commit into from
Apr 2, 2024

Conversation

JoeZijunZhou
Copy link
Collaborator

  • Remove the base ckpt copy to GCS bucket step from the script, let users copy the ckpt themselves and pass the $CHKPT_BUCKET value as an argument of the script.

vipannalla
vipannalla approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@vipannalla vipannalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeZijunZhou JoeZijunZhou merged commit a7e7e81 into main Apr 2, 2024
3 checks passed
@JoeZijunZhou JoeZijunZhou deleted the zijun/script-update branch April 2, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipannalla vipannalla vipannalla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeZijunZhou @vipannalla