Bump Parthenon & Fix SMR #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parthenon's conventions for prolongation operators call over a different domain based on the values which determine the prolonged value. In our case despite working from faces, we are preserving divB in cells, so should be called over the same domain as the default prolongation operator, not over a domain tied to the particular face we're working on This was truly awful to chase down, but at least it's preventable going forward -- documentation of the operator interface will start to solve these sorts of issues.
B field initialization comments & one fix
…nto feature/parthenon-bump
Mark some device functions as forceinline Remove old comments Add new personal machine compile parameters
Try to avoid per-block segments in the ImEx driver. This should make KHARMA faster & more flexible in future Currently still slow since several "mesh" things are loops, but soon^TM
…or boundary ranges
…or boundary ranges
1. Zero EMFs on boundaries in boundaries.cpp. Supercedes B and EMF fixes in b_ct.cpp 2. Remove check_inflow_flux_X because they were confusing, and should always match check_inflow_X
…it's unnecessary and not precedented
Merged
added 10 commits
November 28, 2023 16:55
…ges, Frontier fixes
… to coarse buffers
…sync variable packs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch bumps the Parthenon version and pulls some branches, to test some AMR changes and provide the basis for recording face-centered fields.
It also fixes a nasty artifact previously present at some boundaries in torus/spherical-coordinate runs. This doesn't appear to be the only issue keeping divB==0 in SMR runs, but it at least clears up the obvious/quick issues (and points the way to solving the other, which also only appears in spherical runs).
Finally, this has been the landing spot to clear up compile/run issues in various places and address the bugs with kharma-next generally, so it fixes a handful of such things.
This will be pulled once it passes the tests in an hour or two.