Fix Empty Github .hompage on Github Cards component

AE517 · Oct 21, 2024 · 4021085 · 4021085
1 parent f777034
commit 4021085
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 4 deletions.
diff --git a/...vimfiles/undodir/C%%Users%Guilherme%Dev%JSTS%guilherme-homepage%components%GithubCard.vue b/...vimfiles/undodir/C%%Users%Guilherme%Dev%JSTS%guilherme-homepage%components%GithubCard.vue
diff --git a/$HOME/vimfiles/undodir/C%%Users%Guilherme%Dev%JSTS%guilherme-homepage%pages%projects.vue b/$HOME/vimfiles/undodir/C%%Users%Guilherme%Dev%JSTS%guilherme-homepage%pages%projects.vue
diff --git a/$HOME/vimfiles/undodir/C%%Users%Guilherme%Dev%JSTS%guilherme-homepage%utils%githubApi.ts b/$HOME/vimfiles/undodir/C%%Users%Guilherme%Dev%JSTS%guilherme-homepage%utils%githubApi.ts
diff --git a/components/GithubCard.vue b/components/GithubCard.vue
@@ -20,7 +20,7 @@
               <span><Icon name="mdi:github" size="35" /></span>
             </a>
             <a
-              v-if="repo.homepage !== null"
+              v-if="repo.homepage !== ''"
               :href="repo.homepage"
               target="_blank"
               class="flex flex-row items-center gap-x-2 rounded-lg bg-sundress p-2 px-3 py-2 text-midnight lg:text-lg"

diff --git a/pages/projects.vue b/pages/projects.vue
@@ -8,7 +8,7 @@
             <GithubCard
               v-for="(repo, index) in repositories"
               :repo="repo"
-              :class="`animate-fade-up animate-delay-${500 * index}`"
+              class="animate-fade-up animate-delay-1000"
             />
           </div>
         </div>
@@ -24,7 +24,7 @@ definePageMeta({
 
 const githubResponse: Array<object> = await githubApi();
 const repositories: Array<object> = githubResponse.filter((item: any) => {
-  if (item.name !== 'Guilherme-HJA') return item;
+  if (item.name !== 'Guilherme-HJA') return item; // Github Config ignore
 });
 </script>
 

diff --git a/utils/githubApi.ts b/utils/githubApi.ts
@@ -6,7 +6,7 @@ interface Repo {
   name: string;
   url: string;
   description: string;
-  homepage?: string; //Optional
+  homepage?: string; //Optional | On empty returns ''
   language: string;
   topics: Array<object>;
 }