Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function adodb_key_exists makes needless PHP4 version check #583

Closed
mnewnham opened this issue Jan 5, 2020 · 0 comments
Closed

function adodb_key_exists makes needless PHP4 version check #583

mnewnham opened this issue Jan 5, 2020 · 0 comments
Assignees
@mnewnham
Labels
code cleanup core ADOdb core (library and base classes)
Milestone
v5.21.0

Comments

@mnewnham
Copy link
Contributor

mnewnham commented Jan 5, 2020

Test for version greater than PHP4,01, always true
@mnewnham mnewnham added code cleanup core ADOdb core (library and base classes) labels Jan 5, 2020
@mnewnham mnewnham added this to the v5.21 milestone Jan 5, 2020
@mnewnham mnewnham self-assigned this Jan 5, 2020
@mnewnham mnewnham changed the title function adodb_key exists makes needless PHP4 version check function adodb_key_exists makes needless PHP4 version check Jan 5, 2020
mnewnham added a commit that referenced this issue Jan 5, 2020
@mnewnham
function makes needless PHP4 version Check, see #583
bdfd024
@mnewnham mnewnham closed this as completed Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnewnham mnewnham

Labels
code cleanup core ADOdb core (library and base classes)
Projects
None yet
Milestone
v5.21.0
Development

No branches or pull requests
1 participant
@mnewnham