Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class ADODB_mssqlnative uses PHP error_log() function instead of ADOConnection::outp() #12

Closed
BillX opened this issue May 2, 2014 · 1 comment
Closed

class ADODB_mssqlnative uses PHP error_log() function instead of ADOConnection::outp() #12

BillX opened this issue May 2, 2014 · 1 comment
Labels
enhancement mssqlnative Native driver for SQL Server driver (Tier 1)
Milestone
v5.20

Comments

@BillX
Copy link

BillX commented May 2, 2014

The class ADODB_mssqlnative uses the PHP error_log() function to write extensive debugging information (up to 3000 lines of messages and backtraces per request!) into the PHP error-log, when the debugging is activated.
I seems like someone has forgotten to replace error_log() by ADOConnection::outp(), as it's done in the other driver classes.

Greetings
Bill
dregad added a commit to dregad/ADOdb that referenced this issue May 7, 2014
@dregad
mssqlnative: replace error_log() calls with ADOConnection::outp()
ed06d0b 
Fixes ADOdb#12
@dregad
Copy link
Member

dregad commented May 7, 2014

@BillX thanks for the report. I don't have access to MSSQL, would you be able to test the code in pull request #14 and provide feedback ?

@dregad dregad closed this as completed in 4d21501 May 12, 2014
@dregad dregad modified the milestone: v5.20 Jul 9, 2015
@dregad dregad added mssqlnative Native driver for SQL Server driver (Tier 1) enhancement labels Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement mssqlnative Native driver for SQL Server driver (Tier 1)
Projects
None yet
Milestone
v5.20
Development

No branches or pull requests
2 participants
@dregad @BillX