idlpp: Fix that prevents more characters than specified to be trimmed from file name. #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that malformed includes are generated for isoc++2 in some cases when using
-o maintain-include-namespace
.Steps to reproduce:
main.idl
ospl.idl
typedef octet bar;
Execute
idlpp -l isocpp2 -o maintain-include-namespace main.idl
Notice that the trailing letter l (lower case L) has been stripped of the included file:
main.h
The implementation of trimming of the file name extension
.idl
is implemented as "remove any of the characters '.idl' until none of them is left at the end of the string". This results in the behavior described above.Therefore I propose a simple fix that limits the number of characters removed to the length of the string passed to the
os_str_rtrim
function.