This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
feat: add support for notifications on existing sns topics #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #119
How did you implement it:
This adds new resources for notifications if there's no Topic resource being created.
How can we verify it:
I added some basic tests. I don't think documentation is necessary per se because this is actually what I think most people expected to happen based on the current documentation.
I tested it on my project and it worked. To test it, you just need to have something like:
Todos:
[x] Write tests
[x] Write documentation
[x] Fix linting errors
[x] Provide verification config/commands/resources