Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Member Ignoring Method smell in MaterialDialogPreference class #162

Closed
wants to merge 1 commit into from

Conversation

emaiannone
Copy link

Hi, I'm Emanuele Iannone, a master student at University of Salerno.
Since my bachelor's thesis I have been working on a code smell refactoring plugin called aDoctor, which is able to identify and fix energy-related problems in Android apps.
I launched it on your project, finding different instances of code smells. I chose one of them and let the plugin automatically fix it.
In this case I chose Member Ignoring Method, that is present when a non static method does not use at all instance variables and other non static methods. These kind of smell may have a non trivial impact on energy consumption, as shown in this paper: https://www.sciencedirect.com/science/article/pii/S0950584918301678.
Besides, this kind of refactoring does not impact on the functionalities of your app, so it is totally safe. Let me know if you are interested in this refactoring proposal.

@AChep
Copy link
Owner

AChep commented Jan 19, 2020

Hi,

No, I'm not interested in the "Member Ignoring Method" code smell refactoring. This kind of smell should not affect the performance of the app.

However, other smells from your article are more important. Can you provide a full report?

@emaiannone
Copy link
Author

Hi, and thank you for your feedback. You can just type the paper name on Google and you are able to find it without problems.

@AChep
Copy link
Owner

AChep commented Jan 20, 2020

@emaiannone I'll find the report, or the paper?

@emaiannone
Copy link
Author

@AChep The paper

@AChep AChep closed this Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants