feat(credit-history): add credit credential domain types - #22
Conversation
- Define CreditCategory enum/union - Define CreditStatus with valid, revoked (and revokedAt), and invalid app-level states - Define CreditCredential interface independent from the SDK - Define CreditProfileSummary interface - Place domain types specifically inside apps/credit-history as they are not cross-product
|
@Josue19-08 is attempting to deploy a commit to the ACTA Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new barrel file ChangesCredit domain type definitions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 ACTA Pull Request
Mark with an
xall the checkboxes that apply (like[x])Closes #6
📌 Type of Change
📝 Changes Description
This PR defines the domain model and TypeScript types for the "credit credential" in the
credit-historyproduct, unblocking the subsequent UI and mock issues.Specifically, it adds:
CreditCategory: Union of credential categories with comments (INCOME, EMPLOYMENT, etc.).CreditStatus: Explicit app-level status representingvalid,revoked(with date), andinvalid.CreditCredential: The main app-level interface independent of the@acta-team/credentialsSDK.CreditProfileSummary: Interface for the summary view tracking totals and status counts.Location Decision:
The types were intentionally placed in
apps/credit-history/src/types/index.tsinstead of@acta-products/types. This is because these types are strictly specific to thecredit-historyproduct, whereas@acta-products/typesis intended to remain cross-product and free of product-specific domains.📸 Evidence
VIDEO
🌌 Comments
Code compiles successfully with
pnpm lint,pnpm typecheck, andpnpm buildat the app level. No visible UI strings added, pure domain models.Thank you for contributing to ACTA! We hope you can continue contributing to this project.
Summary by CodeRabbit