Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward-port to R8 next major version #1402

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

mikehardy
Copy link
Contributor

This is in response to this warning and is simply the suggested change, with the intention that it is non-functional / results in the same keep behavior as before

WARNING: /Users/mike/.gradle/caches/8.10.2/transforms/05e2bc486ed1e2d3388799eab04515e2/transformed/acra-core-5.11.4/proguard.txt:15:1-17:1: R8: The current version of R8 implicitly keeps the default constructor for Proguard configuration rules that have no member pattern. If the following rule should continue to keep the default constructor in the next major version of R8, then it must be augmented with the member pattern { void <init>(); } to explicitly keep the default constructor: -keep interface org.acra.ErrorReporter

This is in response to this warning and is simply the suggested change, with the intention that it is non-functional / results in the same keep behavior as before

WARNING: /Users/mike/.gradle/caches/8.10.2/transforms/05e2bc486ed1e2d3388799eab04515e2/transformed/acra-core-5.11.4/proguard.txt:15:1-17:1: R8: The current version of R8 implicitly keeps the default constructor for Proguard configuration rules that have no member pattern. If the following rule should continue to keep the default constructor in the next major version of R8, then it must be augmented with the member pattern `{ void <init>(); }` to explicitly keep the default constructor:
-keep interface org.acra.ErrorReporter
@F43nd1r F43nd1r merged commit 6c212d2 into ACRA:master Nov 2, 2024
2 of 3 checks passed
@mikehardy mikehardy deleted the patch-2 branch November 2, 2024 18:57
@mikehardy
Copy link
Contributor Author

Thanks for the merge and release, I appreciate it 🤜 🤛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants