Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uppercase lettering for invoices and address QRs #196

Closed
Bosch-0 opened this issue Oct 11, 2021 · 1 comment
Closed

Use uppercase lettering for invoices and address QRs #196

Bosch-0 opened this issue Oct 11, 2021 · 1 comment

Comments

@Bosch-0
Copy link

Bosch-0 commented Oct 11, 2021

Phoenix currently uses lower cased bitcoin addresses and Lightning invoices. As outlined here using uppercase lettering results in more efficient QR code generation making them easier to scan.

In summary, when using bech32 addresses in QR codes, consider uppercasing them and any other adjacent characters that can be uppercased in order to produce smaller and less complex QR codes. (However, for all other purposes, bech32 addresses should use all lowercase characters.)
@Bosch-0 Bosch-0 mentioned this issue Oct 11, 2021
Closed
30 tasks
@Bosch-0 Bosch-0 changed the title Use uppercase lettering for invoices and addresses Use uppercase lettering for invoices and address QRs Oct 19, 2021
robbiehanson added a commit that referenced this issue Apr 8, 2022
@robbiehanson
(ios) Use uppercase lettering for invoices and address QRs. Fixes issue
98990d7 
#196
@robbiehanson
Copy link
Contributor

Before:
qrcode_old

After:
qrcode_new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robbiehanson @Bosch-0