Merged
Conversation
Let's take advantage of the upcoming major release to upgrade kotlin and other dependencies. The main point of attention is a breaking change in `kotlinx-datetime`: see https://github.com/Kotlin/kotlinx-datetime?tab=readme-ov-file#deprecation-of-instant.
It is unused since #685.
pm47
commented
Oct 2, 2025
| api("fr.acinq.bitcoin:bitcoin-kmp:${libs.versions.bitcoinkmp.get()}") | ||
| api("org.jetbrains.kotlinx:kotlinx-coroutines-core:${libs.versions.kotlinx.coroutines.get()}") | ||
| api("org.jetbrains.kotlinx:kotlinx-serialization-core:${libs.versions.kotlinx.serialization.get()}") | ||
| api("org.jetbrains.kotlinx:kotlinx-serialization-cbor:${libs.versions.kotlinx.serialization.get()}") |
Member
Author
There was a problem hiding this comment.
@dpad85 This will need to be added to phoenix build.gradle.kts.
t-bast
approved these changes
Oct 3, 2025
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
LGTM since tests seem to pass, but running Phoenix with that updated version is the best test to figure out if there are runtime issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's take advantage of the upcoming major release to upgrade kotlin and other dependencies.
The main point of attention is a breaking change in
kotlinx-datetime: see https://github.com/Kotlin/kotlinx-datetime?tab=readme-ov-file#deprecation-of-instant.