Add more force-close tests for HTLC settlement#772
Merged
Conversation
pm47
reviewed
Mar 25, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/ChannelData.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/ChannelData.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/states/Closing.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/states/Closing.kt
Outdated
Show resolved
Hide resolved
This commit is importing test updates and refactoring to the closing helpers from ACINQ/eclair#3040 We don't relay HTLCs, so we don't have an upstream channel to relay preimages to, but it's important to relay preimages to the payment handler to correctly mark payments as succeeded (or failed) and store the proof of payment.
t-bast
force-pushed
the
additional-force-close-tests
branch
from
a425637 to
4985d1e
Compare
- use collection helpers to simplify some code - introduce `HtlcOverriddenByRemoteCommit`
pm47
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is importing test updates and refactoring to the closing helpers from ACINQ/eclair#3040
We don't relay HTLCs, so we don't have an upstream channel to relay preimages to, but it's important to relay preimages to the payment handler to correctly mark payments as succeeded (or failed) and store the proof of payment.