Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust local mutual close for swap-in #517

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Aug 18, 2023

Instead of explicitly providing txids, we can look at local channel data to extract mutual close txids, because either the tx is unconfirmed and the channel data will still be in Closing state, or the tx is confirmed and the utxo can be used immediately anyway.

This is an alternative to #516.

@pm47 pm47 requested review from dpad85 and t-bast August 18, 2023 09:49
t-bast
t-bast previously approved these changes Aug 18, 2023
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the min-confirmations for swaps matches the confirmations we put in WatchConfirmed, this should work 👍

Instead of explicitly providing txids, we can look at local channel data
to extract mutual close txids, because either the tx is unconfirmed and
the channel data will still be in `Closing` state, otherwise the tx is
confirmed and the utxo can be used immediately anyway.

This is an alternative to #516.
@pm47
Copy link
Member Author

pm47 commented Aug 18, 2023

Rebased.

@pm47 pm47 merged commit e3d1bc5 into master Aug 18, 2023
2 checks passed
@pm47 pm47 deleted the trust-channel-close-swap-in branch August 18, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants