Refactor attribution helpers and commands#3125
Merged
Conversation
We update `Sphinx.scala` to shift hmacs differently to make it easier to implement trampoline attribution in follow-up PRs.
We group attribution data in a dedicated (optional) class for each command instead of always adding more fields, which requires updating a lot of test code whenever we need to change the contents. We take this opportunity to add the trampoline received at field, and update the pending commands DB.
thomash-acinq
previously approved these changes
Jun 30, 2025
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/CommandCodecs.scala
Outdated
Show resolved
Hide resolved
thomash-acinq
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two independent commits that add to
mastermore stuff from #3107 to minimize the diff in the trampoline work.In the first commit, we update the Sphinx helpers that create and decrypt attribution data.
In the second commit, we group attribution data in a dedicated (optional) class for each command (
CMD_FAIL_HTLCandCMD_FULFILL_HTLC) instead of always adding more fields, which requires updating a lot of test code whenever we need to change the contents. We take this opportunity to add thetrampoline_received_atfield, and update the pending commands DB.