Skip to content

Add test for Bolt11 features minimal encoding #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-bast merged 1 commit into from
Apr 8, 2025
Merged

Add test for Bolt11 features minimal encoding #3058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions eclair-core/src/test/scala/fr/acinq/eclair/payment/Bolt11InvoiceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,10 @@ class Bolt11InvoiceSpec extends AnyFunSuite {
"lnbc2500000001p1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqdq5xysxxatsyp3k7enxv4jsxqzpusp5zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zygs9qrsgq0lzc236j96a95uv0m3umg28gclm5lqxtqqwk32uuk4k6673k6n5kfvx3d2h8s295fad45fdhmusm8sjudfhlf6dcsxmfvkeywmjdkxcp99202x",
// Missing payment secret.
"lnbc1qqygh9qpp5s7zxqqqqqqqqqqqqpjqqqqqqqqqqqqqqqqqqcqpjqqqsqqqqqqqqdqqqqqqqqqqqqqqqqqqqqqqqqqqqqquqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqzxqqqqqqqqqqqqqqqy6f523d",
// Missing payment secret.
"lnbc20m1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqs9qrsgq7ea976txfraylvgzuxs8kgcw23ezlrszfnh8r6qtfpr6cxga50aj6txm9rxrydzd06dfeawfk6swupvz4erwnyutnjq7x39ymw6j38gp49qdkj",
// Invalid signature public key recovery id.
"lnbc1qqqqpqqnp4qqqlftcw9qqqqqqqqqqqqygh9qpp5qpp5s7zxqqqqcqpjpqqygh9qpp5s7zxqqqqcqpjpqqlqqqqqqqqqqqqcqqpqqqqqqqqqqqsqqqqqqqqdqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqpqqqqqqqqqqqqqqqqqqqqqqqqqqqqqlqqqcqpjptfqptfqptfqpqqqqqqqqqqqqqqqqqqq8ddm0a"
"lnbc1qqqqpqqnp4qqqlftcw9qqqqqqqqqqqqygh9qpp5qpp5s7zxqqqqcqpjpqqygh9qpp5s7zxqqqqcqpjpqqlqqqqqqqqqqqqcqqpqqqqqqqqqqqsqqqqqqqqdqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqpqqqqqqqqqqqqqqqqqqqqqqqqqqqqqlqqqcqpjptfqptfqptfqpqqqqqqqqqqqqqqqqqqq8ddm0a",
)
for (ref <- refs) {
assert(Bolt11Invoice.fromString(ref).isFailure)
Expand Down Expand Up @@ -528,6 +530,7 @@ class Bolt11InvoiceSpec extends AnyFunSuite {
}

test("feature bits to minimally-encoded feature bytes") {
// Invoice features are encoded as 5-bits chunks, which we decode to bytes.
val testCases = Seq(
(bin" 0010000100000101", hex" 2105"),
(bin" 1010000100000101", hex" a105"),
Expand All @@ -539,8 +542,24 @@ class Bolt11InvoiceSpec extends AnyFunSuite {
(bin"1000110000000000110", hex"046006")
)

for ((bitmask, featureBytes) <- testCases) {
assert(Features(bitmask).toByteVector == featureBytes)
for ((invoiceFeatureBits, featureBytes) <- testCases) {
assert(Features(invoiceFeatureBits).toByteVector == featureBytes)
}
}

test("feature bytes to minimally-encoded feature bits") {
// When encoding features into 5-bits chunks, we want to get rid of leading zeroes.
val testCases = Seq(
(bin"00010000", bin"10000"),
(bin"00100000", bin"0000100000"),
(bin"10010000", bin"0010010000"),
(bin"0000000100000000", bin"0100000000"),
(bin"0000001000000000", bin"1000000000"),
(bin"0000010000000000", bin"000010000000000"),
)

for ((featureBytes, invoiceFeatureBits) <- testCases) {
assert(features2bits(Features(featureBytes)) == invoiceFeatureBits)
}
}

Expand Down