Add support for standard P2A scripts #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
added a commit
to ACINQ/bitcoin-lib
that referenced
this pull request
Oct 20, 2025
In order to support v3 commitments in lightning, we need to use P2A (pay-to-anchor) outputs, which are currently rejected by our script interpreter. See ACINQ/bitcoin-kmp#164
In order to support v3 commitments in lightning, we need to use P2A (pay-to-anchor) outputs, which are currently rejected by our script interpreter. See bitcoin/bitcoin#30352 where this output type was introduced to `bitcoind`. Their amount can be set to dust with bitcoin/bitcoin#30239. Both of those changes are available in Bitcoin Core v29.
sstone
reviewed
Oct 22, 2025
Member
sstone
left a comment
sstone
left a comment
There was a problem hiding this comment.
LGTM, just a few nits. I used the new unit tests to create and send transactions on regtest.
sstone
approved these changes
Oct 22, 2025
t-bast
added a commit
to ACINQ/bitcoin-lib
that referenced
this pull request
Oct 22, 2025
In order to support v3 commitments in lightning, we need to use P2A (pay-to-anchor) outputs, which are currently rejected by our script interpreter. See ACINQ/bitcoin-kmp#164
t-bast
added a commit
to ACINQ/bitcoin-lib
that referenced
this pull request
Oct 22, 2025
In order to support v3 commitments in lightning, we need to use P2A (pay-to-anchor) outputs, which are currently rejected by our script interpreter. See ACINQ/bitcoin-kmp#164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support v3 commitments in lightning, we need to use P2A (pay-to-anchor) outputs, which are currently rejected by our script interpreter.
See bitcoin/bitcoin#30352 where this output type was introduced to
bitcoind. Their amount can be set to dust with bitcoin/bitcoin#30239.Both of those changes are available in Bitcoin Core v29.