Skip to content

Update CDEP'S CMakeLists.txt: redundant calls to "internal" fox code in CDEPS/CMakeLists.txt#21

Merged
chrisb13 merged 2 commits into
mainfrom
18-remove-redundant-calls
Jan 15, 2026
Merged

Update CDEP'S CMakeLists.txt: redundant calls to "internal" fox code in CDEPS/CMakeLists.txt#21
chrisb13 merged 2 commits into
mainfrom
18-remove-redundant-calls

Conversation

@chrisb13
Copy link
Copy Markdown
Contributor

@chrisb13 chrisb13 commented Jan 13, 2026

Closes #18

Redundant calls to "internal" fox code in CDEPS/CMakeLists.txt. See discussion: #18

@chrisb13
Update CMakeLists.txt
5e923f6 
Redundant calls to "internal" fox code in CDEPS/CMakeLists.txt. See discussion: #18
@chrisb13 chrisb13 requested a review from anton-seaice January 13, 2026 05:36
anton-seaice
anton-seaice requested changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test changes before submitting for review - e.g. the CI was failing

Comment thread CDEPS/CMakeLists.txt
Comment thread CDEPS/CMakeLists.txt
@chrisb13
Copy link
Copy Markdown
Contributor Author

chrisb13 commented Jan 15, 2026

@anton-seaice I think this is now building? So if you agree, ready for review.

@anton-seaice
Copy link
Copy Markdown
Collaborator

anton-seaice commented Jan 15, 2026

Yeah - that looks ok. I think it's worth building access-om3 and running a config to be sure.

chrisb13 added a commit to ACCESS-NRI/ACCESS-OM3 that referenced this pull request Jan 15, 2026
@chrisb13
Update spack.yaml
9bb4792 
Testing: ACCESS-NRI/access3-share#21
@chrisb13 chrisb13 mentioned this pull request Jan 15, 2026
Closed
chrisb13 added a commit to ACCESS-NRI/access-om3-configs that referenced this pull request Jan 15, 2026
@chrisb13
Update config.yaml
febcde9 
For:
ACCESS-NRI/ACCESS-OM3#180
ACCESS-NRI/access3-share#21
@chrisb13 chrisb13 mentioned this pull request Jan 15, 2026
Closed
@chrisb13
Copy link
Copy Markdown
Contributor Author

chrisb13 commented Jan 15, 2026

I think it's worth building access-om3 and running a config to be sure.

See:

  1. Testing: CDEP'S CMakeLists.txt: redundant calls to "internal" fox code in CDEPS/CMakeLists.txt ACCESS-OM3#180 (comment)
  2. Testing: CDEP'S CMakeLists.txt: redundant calls to "internal" fox code in CDEPS/CMakeLists.txt access-om3-configs#1047 (comment)

✅ test_repro_historical
✅ test_repro_determinism
✅ test_repro_restart

anton-seaice
anton-seaice approved these changes Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - looks good

@chrisb13 chrisb13 merged commit dc8e5d5 into main Jan 15, 2026
5 checks passed
@chrisb13 chrisb13 deleted the 18-remove-redundant-calls branch January 15, 2026 05:08
@dougiesquire dougiesquire mentioned this pull request Mar 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anton-seaice anton-seaice anton-seaice approved these changes

Assignees

@chrisb13 chrisb13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redundant calls to "internal" fox code in CDEPS/CMakeLists.txt

2 participants

@chrisb13 @anton-seaice