Fix _RowsReader for NVDA 2021.1 - #14
Conversation
…here now it is safer to import them from their module
Since this function is not used anywhere it can quickly become outdated due to changes in NVDA and if someone is interested it is available in the git history.
|
Hi @lukaszgo1 , |
Having a stable release would be appreciated indeed.
Is this really necessary? As far as I can tell there would be no more breaking changes until 2022.1 so what we have now is going to work for at least another year and then we can reconsider. I'm privately pretty interested in CR working at least back to 2019.2 and I'm willing to keep it compatible. What is annoying is the fact that we don't have any user statistics to measure how many people are using Columns Review with a given release of NVDA and we're unlikely to be able to collect them any time soon. |
As Bitbucket repo for 'Todo' repo is gone, do not keep this around anymore.
nvaccess/nvda#12251 refactored
sayAllHandlerand moved its content tospeech.sayAll- this broke_RowsReader. This PR makes_RowsReaderready for NVDA 2021.1. While at it I've made sure that priorities are imported fromspeech.prioritiesand removedrunSilentlywhich was not used any longer and therefore it was quite likely it would not be kept uptodate with the changes in NVDA - it can always be seen in the repository log.