Skip to content

Fix _RowsReader for NVDA 2021.1 - #14

Merged
ABuffEr merged 4 commits into
ABuffEr:masterfrom
lukaszgo1:sayAll2021.1
May 12, 2021
Merged

Fix _RowsReader for NVDA 2021.1#14
ABuffEr merged 4 commits into
ABuffEr:masterfrom
lukaszgo1:sayAll2021.1

Conversation

@lukaszgo1

Copy link
Copy Markdown
Contributor

nvaccess/nvda#12251 refactored sayAllHandler and moved its content to speech.sayAll - this broke _RowsReader. This PR makes _RowsReader ready for NVDA 2021.1. While at it I've made sure that priorities are imported from speech.priorities and removed runSilently which was not used any longer and therefore it was quite likely it would not be kept uptodate with the changes in NVDA - it can always be seen in the repository log.

lukaszgo1 added 4 commits May 10, 2021 12:28
…here now it is safer to import them from their module
Since this function is not used  anywhere it can quickly become outdated due to changes in NVDA and if someone is interested it is available in the git history.
@ABuffEr
ABuffEr merged commit a016d9a into ABuffEr:master May 12, 2021
@ABuffEr

ABuffEr commented May 12, 2021

Copy link
Copy Markdown
Owner

Hi @lukaszgo1 ,
thanks, as usual.
I'm thinking to release a stable version, then cleaning code making it compatible only with 2021.1 and above. Ensuring retro-compatibility is getting tricky.

@lukaszgo1

Copy link
Copy Markdown
Contributor Author

I'm thinking to release a stable version,

Having a stable release would be appreciated indeed.

then cleaning code making it compatible only with 2021.1 and above. Ensuring retro-compatibility is getting tricky.

Is this really necessary? As far as I can tell there would be no more breaking changes until 2022.1 so what we have now is going to work for at least another year and then we can reconsider. I'm privately pretty interested in CR working at least back to 2019.2 and I'm willing to keep it compatible.

What is annoying is the fact that we don't have any user statistics to measure how many people are using Columns Review with a given release of NVDA and we're unlikely to be able to collect them any time soon.

@lukaszgo1
lukaszgo1 deleted the sayAll2021.1 branch May 12, 2021 11:40
ABuffEr pushed a commit that referenced this pull request Jun 1, 2026
As Bitbucket repo for 'Todo' repo is gone, do not keep this around anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants