Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces uint-based (UInt32) variants for reading array/map headers in the core MessagePack reader APIs, and updates the analyzer and its tests to recognize these newer header-reading patterns.
Changes:
- Added
ReadArrayHeaderUInt32/ReadMapHeaderUInt32toMessagePackReader, withint-returning wrappers retained. - Added
TryReadArrayHeader(out uint)/TryReadMapHeader(out uint)toMessagePackStreamingReader, plusint-out wrappers. - Updated converter analyzer logic and tests to treat the new header reader methods as “advanced” patterns (no diagnostics).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Bumps version to 1.3-beta. |
| test/Nerdbank.MessagePack.Analyzers.Tests/ConverterAnalyzersTests.cs | Adds analyzer coverage for converters using the new *HeaderUInt32 reader APIs. |
| src/Nerdbank.MessagePack/MessagePackStreamingReader.cs | Adds uint header-reading overloads and updates skip logic to use them. |
| src/Nerdbank.MessagePack/MessagePackReader.cs | Adds uint header readers and wrapper overloads for existing int-based APIs. |
| src/Nerdbank.MessagePack.Analyzers/ConverterAnalyzers.cs | Treats Read*HeaderUInt32 as advanced read patterns for analyzer purposes. |
This was referenced Aug 27, 2026
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.