Repository navigation
Test that Color deserialization rejects a true marker - #1107
Merged
Merged
Conversation
Covers the reserved boolean true rejection path added in #1103.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test correctly exercises the intended converter branch with no unresolved issues.
0 open findings
What changed in this PR
Adds focused regression coverage ensuring SystemDrawingColorConverter rejects MessagePack true.
Changes:
- Serializes a
truemarker. - Verifies
Colordeserialization throwsMessagePackSerializationException.
| File | Description |
|---|---|
test/Nerdbank.MessagePack.TUnit/BuiltInConverterTests.cs |
Adds the rejection-path test. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
auto-merge was automatically disabled
October 7, 2026 15:32
Pull request was closed
AArnott
enabled auto-merge (squash)
October 7, 2026 15:36
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.4 #1107 +/- ##
==========================================
- Coverage 82.85% 82.83% -0.03%
==========================================
Files 259 259
Lines 21327 21333 +6
Branches 2814 2814
==========================================
Hits 17671 17671
- Misses 2756 2763 +7
+ Partials 900 899 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds coverage for the reserved boolean
truerejection path inSystemDrawingColorConverteradded in #1103, per the Copilot review on #1106. Test-only change.