Separate official and unofficial pipelines #334
Conversation
There was a problem hiding this comment.
This is going to need some changes to the in-house wiki for the template as well, which documents pipelines and their purposes.
And we'll probably want to send a notification within VS Core template users so they know to merge the latest template and adjust their pipelines manually.
Can you take care of all that in tandem with this, and let me know when you're ready for this to merge?
I will first test these changes on the Gladstone repo. Then update the wiki, notify users and finally complete this PR. Thanks for confirming that these changes are reasonable, so I can go ahead with my testing :-) |
|
@matteo-prosperi You're going to need to set up git commit signing and rebase your commits for them to be merged. Repos exist that merge from this template that require commits to be signed, so this repo similarly requires this. |
| @@ -150,7 +150,7 @@ try { | |||
| $YmlReplacements = @{ | |||
| "(?m)^\s+- microbuild`r?`n"="" | |||
| } | |||
| Replace-Placeholders -Path "azure-pipelines\official.yml" -Replacements $YmlReplacements | |||
| Replace-Placeholders -Path "azure-pipelines\unofficial.yml" -Replacements $YmlReplacements | |||
There was a problem hiding this comment.
Shouldn't this replace place-holders in both official.yml and unofficial.yml?
There was a problem hiding this comment.
Only if there are placeholders to be replaced. official.yml no longer has tokens to replace, and the script fails with an error in that case, so that's probably what prompted removing the old one.
Separate official and unofficial pipelines.
This is to satisfy the requirement that pipelines marked as production never use the unofficial templates.