This repository has been archived by the owner on Feb 17, 2024. It is now read-only.
Download endpoint option #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tell the browser through the Content-Disposition header if it should attempt to open or save a file. This approach neither requires disabling the folder protection nor exposes the direct file path.
Supplied second parameter can now switch between forced query-style, forced endpoint-style, and automatic (derived from settings, which is the default) link generation. The forced styles are needed in the settings to show examples to the user.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an option for people who prefer to have download paths instead of a query parameter, e.g.
http://myblog.com/download/123instead ofhttp://myblog.com/?download=123. This can be toggled in the advanced settings, called 'Download Endpoint'.It's just the last 3 commits which build upon my previous pull request #55.