Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0 #12

Merged
merged 57 commits into from
Dec 4, 2015
Merged

Version 2.0.0 #12

merged 57 commits into from
Dec 4, 2015

Conversation

A21z
Copy link
Owner

@A21z A21z commented Nov 23, 2015

No description provided.

@A21z
Copy link
Owner Author

A21z commented Nov 25, 2015

Hey @signorekai, thank you for contributing! Do you mind if I merge back your work for a 2.0.0 release?

@signorekai
Copy link
Contributor

Hey sure, go ahead. You might want to edit the readme though, I changed the
git clone URL to my repository.

On Wed, Nov 25, 2015, 08:34 Alban Perillat-Merceroz <
[email protected]> wrote:

Hey @signorekai https://github.com/signorekai, thank you for
contributing! Do you mind if I merge back your work for a 2.0.0 release?


Reply to this email directly or view it on GitHub
#12 (comment).

@signorekai
Copy link
Contributor

By the way, I disabled the IP checking because I was too busy/lazy to get
it working. Might want to reimplement that too; it's on my roadmap but I
haven't got the time.

On Wed, Nov 25, 2015, 20:14 Alfred Lau [email protected] wrote:

Hey sure, go ahead. You might want to edit the readme though, I changed
the git clone URL to my repository.

On Wed, Nov 25, 2015, 08:34 Alban Perillat-Merceroz <
[email protected]> wrote:

Hey @signorekai https://github.com/signorekai, thank you for
contributing! Do you mind if I merge back your work for a 2.0.0 release?


Reply to this email directly or view it on GitHub
#12 (comment).

@A21z
Copy link
Owner Author

A21z commented Nov 29, 2015

Great, thanks.
I've refactored a bit and re-activated IP checking for Bitbucket. I don't know Contentful enough but feel free to add it later.
I'll merge this once I've run some thorough manual testing.

@A21z
Copy link
Owner Author

A21z commented Dec 4, 2015

I've run some tests, it should be good now.
Also fixed #10

A21z added a commit that referenced this pull request Dec 4, 2015
@A21z A21z merged commit 609d19d into master Dec 4, 2015
@A21z A21z mentioned this pull request Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants