Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add needs field to hooks + slots #10

Merged
merged 22 commits into from
Oct 16, 2024
Merged

Add needs field to hooks + slots #10

merged 22 commits into from
Oct 16, 2024

Conversation

andriygm
Copy link
Member

@andriygm andriygm commented Aug 8, 2024

  • also adds a project name top-level config in addition to the automatic project name discovery (+ added tests for regression)
  • also adds a new Project struct to the lib interface. consumers first load_project and can then invoke main spackle functionality for that project (e.g. copy, template, run hooks). this also means consumers don't need to provide as much context when executing these.

@andriygm andriygm requested a review from dpastoor August 12, 2024 20:20
@andriygm andriygm linked an issue Aug 12, 2024 that may be closed by this pull request
@andriygm andriygm marked this pull request as ready for review August 13, 2024 17:17
@andriygm
Copy link
Member Author

andriygm commented Sep 5, 2024

@dpastoor main is merged in, still need to do some final fixes regarding slot/hook validation + context passing but mostly there

@andriygm
Copy link
Member Author

andriygm commented Sep 6, 2024

new "_output_name" universal corresponds to the output path name
Screenshot 2024-09-06 at 12 20 22 PM

Screenshot 2024-09-06 at 12 22 56 PM Screenshot 2024-09-06 at 12 23 09 PM

fixes #12

@andriygm andriygm linked an issue Sep 6, 2024 that may be closed by this pull request
@andriygm andriygm merged commit 8e09d3e into main Oct 16, 2024
2 checks passed
@andriygm andriygm deleted the dep-resolution branch October 16, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

project_name uses the project folder instead of the output folder Allow slot + hook dependencies
1 participant