Timer bug #21
Merged
Timer bug #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Case 1: SuccessScreen.Recording.2024-12-11.at.1.20.59.PM.movCase 2: Error in app with rstudioapi >= 0.16.0Screen.Recording.2024-12-11.at.1.21.41.PM.movCase 3: Error in app with rstudioapi < 0.16.0Screen.Recording.2024-12-11.at.1.31.32.PM.mov |
wes-a2ai
requested changes
Dec 11, 2024
|
New tests: success with rstudioapi >= 0.16.0Screen.Recording.2024-12-11.at.2.35.54.PM.movsuccess with rstudioapi < 0.16.0Screen.Recording.2024-12-11.at.2.34.37.PM.moverror with rstudioapi >= 0.16.0In this case, the error is caught right away and the user is notified Screen.Recording.2024-12-11.at.2.33.12.PM.moverror with rstudioapi < 0.16.0In this case, the getJobStatus function dne, so the user just has to wait it out Screen.Recording.2024-12-11.at.2.33.40.PM.mov |
wes-a2ai
reviewed
Dec 11, 2024
|
Also saw same results in my testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.