Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading urfave/cli to v3 #3455

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Upgrading urfave/cli to v3 #3455

wants to merge 1 commit into from

Conversation

oxisto
Copy link
Contributor

@oxisto oxisto commented Dec 24, 2024

This PR upgrades urfave/cli to v3. This has the advantage to get rid of three dependencies, including blackfriday, which is semi-unmaintained and frankly a markdown processor is simply unexpected as a dependency for a gql code-generator.

Unfortunatly, the v3 is still in beta, so you might want to hold actually merging this, once v3 is officially released. At least the changes are prepared then.

This PR upgrades `urfave/cli` to v3. This has the advantage to get rid of three dependencies, including blackfriday, which is semi-unmaintained and frankly a markdown processor is simply unexpected as a dependency for a gql code-generator.

Unfortunatly, the v3 is still in beta, so you might want to hold actually merging this, once v3 is officially released. At least the changes are prepared then.
@coveralls
Copy link

Coverage Status

coverage: 73.913% (+0.05%) from 73.861%
when pulling 06303c0 on oxisto:master
into 663d013 on 99designs:master.

@StevenACoffman StevenACoffman marked this pull request as draft December 25, 2024 01:06
@StevenACoffman
Copy link
Collaborator

Hey, thanks for the heads up and for this work! I converted this to a draft until 3.0.0 releases, and then I'd love it if you can update it and convert it back to ready to review. If you could ping me, I'd appreciate it, as I might not otherwise notice when 3.0.0 is released.

@oxisto
Copy link
Contributor Author

oxisto commented Dec 25, 2024

Hey, thanks for the heads up and for this work! I converted this to a draft until 3.0.0 releases, and then I'd love it if you can update it and convert it back to ready to review. If you could ping me, I'd appreciate it, as I might not otherwise notice when 3.0.0 is released.

Thanks! I am not affiliated with the project, but just using it in another project. There is a meta thread abut the 3.0.0 release, which I subscribed to and will most likely get some information about a release then. See urfave/cli#833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants